Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResetAllButton should handle interruptSubtreeInput #861

Open
pixelzoom opened this issue Jul 15, 2024 · 0 comments
Open

ResetAllButton should handle interruptSubtreeInput #861

pixelzoom opened this issue Jul 15, 2024 · 0 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 15, 2024

From 7/15/24 developer meeting...

When ResetAllButton is pressed, the ScreenView's interruptSubtreeInput should be called, to interrupt any interactions that are in process.

This requirement is currently implemented by duplicating something like this over and over in sim-specific code.

new ResetAllButton( {
  listener: () => {
    this.interruptSubtreeInput();
    ...
  },
  ...
);

The developer must remember to do this. QA must test it. And many sims are NOT doing this -- BASE, bending-light, CLB, charges-and-fields,... (search for "new ResetAllButton")

So it would be better if ResetAllButton handled this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants