You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In phetsims/greenhouse-effect#341 I was asked to remove the phet-io instrumentation of the text in a button due to changes in the way instrumentation of text is done. Upon investigation, it looks like the instrumentation of the text is actually in the TextPushButton common code class. There is an existing general issue about removing text instrumentation, see https://github.com/phetsims/phet-io/issues/1952, and I guess this is a specific instance of a case where that change is needed.
Looking at the code in TextPushButton, I think all that needs to happen is that the tandem is removed from the text node. Here's an excerpt:
I am reluctant to do this without first consulting with the phet-io team, since I believe this will change the phet-io API for a number of sims, and I'm not sure how we are supposed to handle that.
In phetsims/greenhouse-effect#341 I was asked to remove the phet-io instrumentation of the text in a button due to changes in the way instrumentation of text is done. Upon investigation, it looks like the instrumentation of the text is actually in the
TextPushButton
common code class. There is an existing general issue about removing text instrumentation, see https://github.com/phetsims/phet-io/issues/1952, and I guess this is a specific instance of a case where that change is needed.Looking at the code in
TextPushButton
, I think all that needs to happen is that the tandem is removed from the text node. Here's an excerpt:The text was updated successfully, but these errors were encountered: