Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate making sound files smaller #153

Open
jbphet opened this issue Oct 7, 2021 · 1 comment
Open

Investigate making sound files smaller #153

jbphet opened this issue Oct 7, 2021 · 1 comment
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Oct 7, 2021

The process of addressing #151 and #152 have made the sound files a bit bigger. The code for each sound file comes from modulify, but perhaps this can be simplified and instead of creating a 46 line file everything time (which is what it does as of this writing), I could consolidate the code into a separate file that is just referenced by modulify. While this wouldn't likely be a huge gain in terms of reducing the file size, it would help to some degree.

@jbphet jbphet self-assigned this Oct 7, 2021
@pixelzoom
Copy link
Contributor

+1 for addressing this. The current code comes from modulify because that's what it's been implemented to generate. Regardless of whether (or maybe even especially when) it's generated code, it's always preferrable to factor out duplicated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants