-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review TypeScript conversion #161
Comments
For reference, the issue under which the TS port was done is #160. |
The typescript overall looks great! I feel like I only have nit-picky things where I've done things differently. Notably:
EDIT: I (@jbphet) changed the list to checkboxes. |
jbphet
added a commit
that referenced
this issue
Apr 22, 2022
jbphet
added a commit
that referenced
this issue
Apr 22, 2022
…ions weren't really optional, see #161
jbphet
added a commit
that referenced
this issue
Apr 22, 2022
jbphet
added a commit
that referenced
this issue
May 18, 2022
jbphet
added a commit
that referenced
this issue
May 18, 2022
jbphet
added a commit
that referenced
this issue
May 18, 2022
jbphet
added a commit
that referenced
this issue
May 18, 2022
I've addressed all of the suggestions - thanks for the review @jonathanolson! Closing. |
jbphet
added a commit
that referenced
this issue
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In today's developer/typescript meeting we decided to have set of reviews on new and converted TypeScript code in order to get feedback, cross pollinate techniques and ideas, and generally improve the quality of the code. I requested that tambo be reviewed, and @jonathanolson was assigned to do it.
I've set up a meeting for tomorrow (4/15/2022) with @jonathanolson to review some specific questions that I have and set some general direction for the review.
The text was updated successfully, but these errors were encountered: