Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LevelCompletedNode and AllLevelsCompleted should be Dialogs #110

Open
8 tasks
pixelzoom opened this issue Jul 13, 2022 · 2 comments
Open
8 tasks

LevelCompletedNode and AllLevelsCompleted should be Dialogs #110

pixelzoom opened this issue Jul 13, 2022 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

LevelCompletedNode should be a modal Dialog. It's currently a subclass of Panel. Unless you write sim-specific code, the user can still interact with the sim while it's displayed. And clicking outside of it does not dismiss it. There's no close (X) button. And the programming API is totally different.

For example, in vegas demo, I can still interact with all of the controls behind this pseudo-dialog, and I have to press 'Continue' to make it disappear.

screenshot_1778

LevelCompletedNode is used in sims that have games with a finite number of challenges. That currently includes:

  • area-builder
  • area-model-common
  • arithmetic
  • balancing-chemical-equations
  • build-an-atom
  • fractions-common
  • graphing-lines
  • reactants-products-and-leftovers
@pixelzoom pixelzoom self-assigned this Jul 13, 2022
@pixelzoom
Copy link
Contributor Author

AllLevelsCompletedNode has the same problems, and should be a Dialog. It is used by:

  • expression-exchange
  • fractions-common

@pixelzoom pixelzoom changed the title LevelCompletedNode should be a Dialog LevelCompletedNode and AllLevelsCompleted should be Dialogs Jul 13, 2022
@pixelzoom pixelzoom removed their assignment Jul 13, 2022
@pixelzoom
Copy link
Contributor Author

I took a running start at this, and it's going to be a big chunk of work, easily an entire day. And there are PhET-iO issues to deal with -- which we haven't encountered only because a "finite challenges" sim has not been instrumented yet. So I'm unassigning for now. This will probably need to be addressed when any of the sims notes above needs to be republished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant