Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert RewardNode to use Sprite #84

Open
samreid opened this issue Sep 28, 2020 · 3 comments
Open

Convert RewardNode to use Sprite #84

samreid opened this issue Sep 28, 2020 · 3 comments

Comments

@samreid
Copy link
Member

samreid commented Sep 28, 2020

During #82 I noticed that even on a very speedy machine the sprites in rewardNode do not animate smoothly, and there is code overhead in setting up a CanvasNode, and calling drawImage on the reward items. Perhaps it would be simpler and have smoother performance to rewrite using SpriteNode? RewardNode already internally converts nodes to images, so that part is already done.

@jonathanolson or @pixelzoom you are more familiar with Sprite, is this a good idea?

@pixelzoom
Copy link
Contributor

RewardNode seems like a perfect fit for Sprites.js -- transforming and drawing many instances of a small set of images. It would probably be < 2 hours work for someone who is already familiar with Sprites.

@pixelzoom pixelzoom removed their assignment Sep 28, 2020
@samreid
Copy link
Member Author

samreid commented Sep 28, 2020

@ariel-phet can you please assign and prioritize?

@pixelzoom
Copy link
Contributor

Re-assigning to @kathy-phet to prioritize, since that's no longer @ariel-phet's responsibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants