Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sounds were not added to category 'ui-sounds'. #98

Closed
pixelzoom opened this issue Nov 15, 2021 · 3 comments
Closed

Sounds were not added to category 'ui-sounds'. #98

pixelzoom opened this issue Nov 15, 2021 · 3 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Nov 15, 2021

This is a prerequisite to implementing the proposed fix in #77 (comment).

When sound was added for vegas components in #89, they were apparently not assigned to category 'ui-sounds'. Reproducible by adding this to a sim with a Game, like Equality Explorer:

soundManager.setOutputLevelForCategory( 'user-interface', 0 );

This should turn off all 'ui-sounds'. But some vegas sounds continue to play. (GameAudioPlayer sounds are expect to play - those are not the sounds we're tallking about here.) This is definitely a problem for LevelSelectionButton, and the "back" button in the scoreboard. I don't recall what other sounds were added in #89, but it's probably a problem for them too.

@jbphet
Copy link
Contributor

jbphet commented Nov 15, 2021

I've added the level selection and back buttons into the "user-interface" sound category. I tested it by adding code to set the output level for this category to zero in equality-explorer-main.js, and it seemed to behave as descired.

Assigning to @pixelzoom to review and to cherry-pick into an RC for which this change is needed.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Nov 16, 2021

I verified that this is working as desired in Equality Explorer. I'll leave self-assigned until we decide how to address #77, which will determine whether I need to cherry-pick for phetsims/equality-explorer#177.

@pixelzoom
Copy link
Contributor Author

I've completed the cherry-picks for phetsims/equality-explorer#177. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants