Misleading "click" naming in WaveInterferenceSlider.js

[pixelzoom]

Noted while working on phetsims/fourier-making-waves#56, because I was told to use WaveInterferenceSlider.js as an example.

In WaveInterferenceSlider.js

const MIN_INTER_CLICK_TIME = ( 1 / 60 * 1000 ) * 2; // min time between clicks, in milliseconds, empirically determined
...
    // Keep track of the last time a sound was played so that we don't play too often
    let timeOfLastClick = 0;

Naming is really confusing here. If this did have something to do with "clicks", it would be better to call it "press", because click is mouse specific. And in fact it has nothing to do with click or press. It's the time between drag events.

Consider renaming for the benefit of future readers/maintainers.

[samreid]

I believe the clicks refer to the clicking sound that is made as you move across the slider tick marks. I'll update the documentation accordingly.

[samreid]

I updated the documentation, but couldn't think of a superior variable name. @pixelzoom what do you recommend?

[pixelzoom]

Doc in 409e3b5 looks OK.

phetsims/ratio-and-proportion@e0bf77f looks unrelated to this issue, probably an accidental commit.

Closing.

[samreid]

In phetsims/ratio-and-proportion@e0bf77f I noticed a copy/pasted version of the bad documentation, so I updated it at the same time.