-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading "click" naming in WaveInterferenceSlider.js #520
Comments
I believe the clicks refer to the clicking sound that is made as you move across the slider tick marks. I'll update the documentation accordingly. |
I updated the documentation, but couldn't think of a superior variable name. @pixelzoom what do you recommend? |
Doc in 409e3b5 looks OK. phetsims/ratio-and-proportion@e0bf77f looks unrelated to this issue, probably an accidental commit. Closing. |
In phetsims/ratio-and-proportion@e0bf77f I noticed a copy/pasted version of the bad documentation, so I updated it at the same time. |
Noted while working on phetsims/fourier-making-waves#56, because I was told to use WaveInterferenceSlider.js as an example.
In WaveInterferenceSlider.js
Naming is really confusing here. If this did have something to do with "clicks", it would be better to call it "press", because click is mouse specific. And in fact it has nothing to do with click or press. It's the time between drag events.
Consider renaming for the benefit of future readers/maintainers.
The text was updated successfully, but these errors were encountered: