-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No style in the css for class="Grid-cell u-1of3" #92
Comments
The other CSS you're referencing can be found in the media.css ultility file. But I can see how this could be confusing. I'll look into adding extra links to these other files where it makes sense. |
Would those files be combined if I cloned and built the repo? |
Building the repo produces the files that are on https://philipwalton.github.io/solved-by-flexbox/, so yes. |
In the interests of BEM methodology I suggest refactoring u-* to Util-* or Utility-* |
Technically the methodology used on this site is SUIT CSS, which makes use of utility classes. |
@philipwalton Also why |
@rajasimon Probably because |
I agree with @getsetbro. This confused me, too. I'd appreciate if you could include the full CSS in the examples on the page. |
Confusing indeed 😞 |
Thanks for your work on this!
The demo page shows you can set classes on a Grid-cell like:
class="Grid-cell u-1of2"
But the css linked on the page has no classes for that: https://github.com/philipwalton/solved-by-flexbox/blob/master/assets/css/components/grid.css
There only a class for a .Grid-cell in a container of "Grid--1of3":
The text was updated successfully, but these errors were encountered: