Question about RV Periodogram / Lomb-Scargle periodograms

[mpogacea]

Hello developers, I have a question concerning spectroscopic binaries (SB). Starting from RV observations of a SB1 or SB2 system at my disposal, I would like Phoebe to estimate the orbital period using a periodogram. Here is the code I am using:

import phoebe
from phoebe import u
import numpy as np

b = phoebe.default_binary()

ifn = 'path to RV observation data'
times, rvs, ervs = np.loadtxt(ifn, unpack=True, usecols=(1,2,3), delimiters='|')
b.add_dataset('rv', times=times, rvs=rvs, ervs=ervs, overwrite=True)

b.add_solver('estimator.rv_periodogram', solver='rv_periodogram_solv')
b.run_solver('rv_periodogram_solv')
print(b.get_parameter('period@binary').value)

Here is the response I got: "1.0" which is the default binary bundle value given to the binary period. If instead, I chose a particular value for the period however close to the actual period of the SB using b.set_value(), Phoebe will return the new set_value. It feels like Phoebe always returns the "initial"/ set_value bundle period value without using the RV measurements provided.

My question: am I properly coding the periodogram? Is there a way to estimate the period of a SB based on the RV measurements provided? I have also tried using optimizers, like nedler_mead or differential evolution in hopes of achieving better estimates of the period, but I still have some problems when flipping some constraints; however that is not the main point.

Thank you very much in advance for your help!

[kecnry]

run_solver results in a "solution" that proposes changes to the values, but the face-values themselves are not actually updated until calling adopt_solution (allowing for you to inspect the proposed changes and decide which, if any, you want to accept).

To see the changes that would be applied when adopting, call b.adopt_solution(trial_run=True), or to apply them directly, call b.adopt_solution() (where you may have to provide the label of the solution if there are more than one). Once adopted, the get_parameter or get_value calls should show the new value.