Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflection support for contacts #18

Open
kecnry opened this issue Aug 22, 2016 · 3 comments
Open

reflection support for contacts #18

kecnry opened this issue Aug 22, 2016 · 3 comments
Assignees
Labels
feature request for a new feature

Comments

@kecnry
Copy link
Member

kecnry commented Aug 22, 2016

Reflection support is currently implemented in phoebe-lib and has been incorporated into the backend but still needs thorough testing.

  • [2.0b] test reflection vs legacy (now PASS, see reflection nosetest fails #39)
  • [oc support] backend support for overcontacts (already exists in libphoebe)
@kecnry kecnry added this to the 2.0b milestone Aug 22, 2016
@kecnry kecnry added feature request for a new feature and removed enhancement labels Aug 23, 2016
@kecnry
Copy link
Member Author

kecnry commented Aug 31, 2016

reflection nosetests now pass (see #39), so moving milestone to oc support

@kecnry kecnry modified the milestones: oc support, 2.0b Aug 31, 2016
@kecnry kecnry changed the title reflection support reflection support for overcontacts Sep 1, 2016
@horvatm
Copy link
Member

horvatm commented Sep 27, 2016

This should work with general reflection routines, not for n-convex-bodies. I don't know how far is the logic outside libphoebe to handle this.

@kecnry
Copy link
Member Author

kecnry commented Sep 13, 2018

this should be implemented, but I don't know how well its been tested. We need to write a test (preferably nosetest) for this.

@kecnry kecnry changed the title reflection support for overcontacts reflection support for contacts Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants