Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export decoupled luminosities in legacy wrapper #59

Open
bpablo opened this issue Aug 31, 2016 · 2 comments
Open

export decoupled luminosities in legacy wrapper #59

bpablo opened this issue Aug 31, 2016 · 2 comments
Assignees
@kecnry @bpablo
Labels
enhancement testing
Milestone
2.0

Comments

@bpablo
Copy link
Contributor

bpablo commented Aug 31, 2016

In phoebe1 only unconstrained systems have decoupled luminosities. The model parameter is no currently set by the wrapper.
@bpablo bpablo self-assigned this Aug 31, 2016
@kecnry
Copy link
Member

kecnry commented Aug 31, 2016

and let's not forget to do the opposite direction as well so that from_legacy can properly set decoupled luminosities when phoebe1's model parameter is "unconstrained"

@kecnry kecnry added this to the 2.0 milestone Aug 31, 2016
@kecnry
Copy link
Member

kecnry commented Jan 26, 2017

see commit f21d89a

still needs thorough testing and nosetests, so adding myself to this issue

@kecnry kecnry self-assigned this Jan 26, 2017
@kecnry kecnry added the testing label Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kecnry kecnry

@bpablo bpablo

Labels
enhancement testing
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@kecnry @bpablo