Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online passband history query not working #973

Closed
aprsa opened this issue Oct 26, 2024 · 3 comments
Closed

Online passband history query not working #973

aprsa opened this issue Oct 26, 2024 · 3 comments
Assignees

Comments

@aprsa
Copy link
Contributor

aprsa commented Oct 26, 2024

phoebe.list_passband_online_history("Stromgren:u")
Traceback (most recent call last):
File "", line 1, in
File "/home/andrej/projects/phoebe/phoebe/phoebe/atmospheres/passbands.py", line 2206, in list_passband_online_history
return {k:v for k,v in all_history.items() if installed_timestamp < _timestamp_to_dt(k)} if installed_timestamp is not None else all_history
^^^^^^^^^^^^^^^^^
AttributeError: 'list' object has no attribute 'items'

@aprsa aprsa self-assigned this Oct 26, 2024
@aprsa
Copy link
Contributor Author

aprsa commented Nov 7, 2024

This PR fixes the history issue and supports ISO timestamps.

@aprsa
Copy link
Contributor Author

aprsa commented Nov 7, 2024

The server is still not fully backwards-compatible, investigating.

@aprsa
Copy link
Contributor Author

aprsa commented Nov 11, 2024

Fixed by this PR.

@aprsa aprsa closed this as completed Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant