Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically wait for promises on destruct. #33

Open
Nyholm opened this issue Jul 4, 2017 · 1 comment
Open

Automatically wait for promises on destruct. #33

Nyholm opened this issue Jul 4, 2017 · 1 comment

Comments

@Nyholm
Copy link
Member

Nyholm commented Jul 4, 2017

From https://github.com/php-http/httplug-quickstart/pull/1#issuecomment-312874509

Currently Guzzle automatically calls the queue in the shutdown handler or can be called manually. The queue is responsible for waiting on Promises. In our cURL client the only solution right now is to manually do that for every promise.

@sagikazarmark
Copy link
Member

Not sure if this is precise. On destruct of what? The client? That would require the keep the queue inside the client which I am not sure we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants