Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream_context_create silently ignores invalid options #16105

Open
aliber4079 opened this issue Sep 28, 2024 · 2 comments
Open

stream_context_create silently ignores invalid options #16105

aliber4079 opened this issue Sep 28, 2024 · 2 comments

Comments

@aliber4079
Copy link

Description

for example
$context=stream_context_create([ 'ssl' => [ 'verify_peername' => FALSE, ] ]);
the property verify_peername should be verify_peer_name but $context is not FALSE and no error is reported

@bukka
Copy link
Member

bukka commented Sep 28, 2024

I think it's reasonable feature request. The question is if it should be deprecation (next minor) and then error (next major) or just warning or notice...

@Girgias
Copy link
Member

Girgias commented Sep 28, 2024

The standard approach would be to add a warning and promote it to throwing a ValueError at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants