-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Built-in webserver not passing header correctly #16137
Labels
Comments
not familiar that much with cli but seems to me the callback to concat value to headers need to handle Forwarded based headers values differently to address it, will start to look at it later today. |
devnexen
added a commit
to devnexen/php-src
that referenced
this issue
Oct 1, 2024
Those are meant to have 1 or plus values separated by a comma even if the client set them separately.
devnexen
added a commit
to devnexen/php-src
that referenced
this issue
Oct 2, 2024
Those are meant to have 1 or plus values separated by a comma even if the client set them separately.
devnexen
added a commit
to devnexen/php-src
that referenced
this issue
Oct 3, 2024
Those are meant to have 1 or plus values separated by a comma even if the client set them separately.
devnexen
added a commit
to devnexen/php-src
that referenced
this issue
Oct 3, 2024
Those are meant to have 1 or plus values separated by a comma even if the client set them separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
E.g. the ´Forwarded` header might appear more then once, NGinx and Apache correctly merge them into a comma separated list.
But the built-in server does not and just passes the first header set.
To test:
Run with:
Test with curl:
Expected output:
for=127.0.0.1,for=unknown
PHP Version
8.3.11
Operating System
openSUSE Tumbleweek
The text was updated successfully, but these errors were encountered: