From 3f5534f77660307590bcae926d3033c8c22e0fc8 Mon Sep 17 00:00:00 2001
From: Jaapio <jaap@ijaap.nl>
Date: Wed, 14 Aug 2024 21:57:29 +0200
Subject: [PATCH] Remove abstract factory

---
 .../Factory/AbstractImplementsFactory.php     | 19 -------------------
 .../Tags/Factory/ImplementsFactory.php        |  2 +-
 src/DocBlock/Tags/Factory/TemplateFactory.php |  3 ++-
 .../Factory/TemplateImplementsFactory.php     |  2 +-
 4 files changed, 4 insertions(+), 22 deletions(-)
 delete mode 100644 src/DocBlock/Tags/Factory/AbstractImplementsFactory.php

diff --git a/src/DocBlock/Tags/Factory/AbstractImplementsFactory.php b/src/DocBlock/Tags/Factory/AbstractImplementsFactory.php
deleted file mode 100644
index 7c70de8c..00000000
--- a/src/DocBlock/Tags/Factory/AbstractImplementsFactory.php
+++ /dev/null
@@ -1,19 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace phpDocumentor\Reflection\DocBlock\Tags\Factory;
-
-use phpDocumentor\Reflection\DocBlock\DescriptionFactory;
-use phpDocumentor\Reflection\TypeResolver;
-use phpDocumentor\Reflection\Types\Context;
-use PHPStan\PhpDocParser\Ast\PhpDoc\ImplementsTagValueNode;
-use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagNode;
-
-/**
- * @internal This class is not part of the BC promise of this library.
- */
-abstract class AbstractImplementsFactory implements PHPStanFactory
-{
-
-}
diff --git a/src/DocBlock/Tags/Factory/ImplementsFactory.php b/src/DocBlock/Tags/Factory/ImplementsFactory.php
index 70b72a14..a16e8c4b 100644
--- a/src/DocBlock/Tags/Factory/ImplementsFactory.php
+++ b/src/DocBlock/Tags/Factory/ImplementsFactory.php
@@ -18,7 +18,7 @@
 /**
  * @internal This class is not part of the BC promise of this library.
  */
-final class ImplementsFactory extends AbstractImplementsFactory
+final class ImplementsFactory implements Factory
 {
     private DescriptionFactory $descriptionFactory;
     private TypeResolver $typeResolver;
diff --git a/src/DocBlock/Tags/Factory/TemplateFactory.php b/src/DocBlock/Tags/Factory/TemplateFactory.php
index d2a4e947..0ebf26b5 100644
--- a/src/DocBlock/Tags/Factory/TemplateFactory.php
+++ b/src/DocBlock/Tags/Factory/TemplateFactory.php
@@ -4,6 +4,7 @@
 
 namespace phpDocumentor\Reflection\DocBlock\Tags\Factory;
 
+use InvalidArgumentException;
 use phpDocumentor\Reflection\DocBlock\DescriptionFactory;
 use phpDocumentor\Reflection\DocBlock\Tag;
 use phpDocumentor\Reflection\DocBlock\Tags\Template;
@@ -36,7 +37,7 @@ public function create(PhpDocTagNode $node, Context $context): Tag
         Assert::isInstanceOf($tagValue, TemplateTagValueNode::class);
         $name = $tagValue->name;
         if ($name === '') {
-            throw new \InvalidArgumentException('Template name cannot be empty');
+            throw new InvalidArgumentException('Template name cannot be empty');
         }
 
         $description = $tagValue->getAttribute('description');
diff --git a/src/DocBlock/Tags/Factory/TemplateImplementsFactory.php b/src/DocBlock/Tags/Factory/TemplateImplementsFactory.php
index b01fd90f..9ae82425 100644
--- a/src/DocBlock/Tags/Factory/TemplateImplementsFactory.php
+++ b/src/DocBlock/Tags/Factory/TemplateImplementsFactory.php
@@ -18,7 +18,7 @@
 /**
  * @internal This class is not part of the BC promise of this library.
  */
-final class TemplateImplementsFactory extends AbstractImplementsFactory
+final class TemplateImplementsFactory implements Factory
 {
     private DescriptionFactory $descriptionFactory;
     private TypeResolver $typeResolver;