Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore author rating functionality #364

Open
battye opened this issue Sep 23, 2023 · 0 comments
Open

Restore author rating functionality #364

battye opened this issue Sep 23, 2023 · 0 comments

Comments

@battye
Copy link
Member

battye commented Sep 23, 2023

This seems to have been lost when we transitioned to controllers.

Reporter: prototech
Created: 11/Oct/15 7:45 PM

Comments:

battye added a comment - 21/Nov/18 2:04 PM
Was the original functionality for this that a user could rate a particular author, or did all votes for a contribution by an author(s) get aggregated into their author rating?

David Colón added a comment - 22/Nov/18 2:56 PM
Pretty sure it was only about the author. But I like the idea of aggregating their other contributions to determine the author rating.

battye added a comment - 23/Nov/18 4:20 PM
When I was poking around the other day I didn't see much trace of the original author ratings functionality so I don't think it'll be any extra effort doing it one way or the other.
The only thing I can think of is would there be any reason to handle co-authors and past contributors differently? Or would a contribution rating apply equally to anyone who has had a hand in its creation?

David Colón added a comment - 27/Nov/18 4:08 PM
If we go with deriving the rating from the contributions then the rating should only apply to current authors and I'm thinking it should apply the same to all of them even if they're listed as co-authors. There are instances where the primary author either doesn't do anything or just manages the contribution whereas all the work is done by the co-authors so it's kind of hard to make a determination from there.
Or...we just do it per author and initialize the author ratings based on an aggregation of all of their contributions.

battye added a comment - 06/Dec/18 11:21 AM
Oops I thought I had responded to this one. That sounds good to me. I'll start off with adding the functionality that aggregates it from their contributions - because with either approach (1/ purely aggregation, 2/ initialise from aggregation and then use a custom author rating) we'll still need the aggregation component. Then I guess we can determine if that's enough or whether we add the custom author ratings on to that.

David Colón added a comment - 06/Dec/18 2:54 PM
The initialization can just be done through a migration, but yeah you should probably have a function to take care of continuing the aggregation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant