Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsinged git tag in daily-composer #10

Open
emanuelb opened this issue May 18, 2017 · 2 comments
Open

unsinged git tag in daily-composer #10

emanuelb opened this issue May 18, 2017 · 2 comments

Comments

@emanuelb
Copy link

in "scripts/website/daily-composer"

    # Create tag
git tag -a -m "Composer tag for $tag" $newtag

which will create unsigned tag:
https://github.com/phpmyadmin/composer/releases/tag/4.7.0

@nijel
Copy link
Contributor

nijel commented May 22, 2017

That's true - it's created automatically from the cron job, so the signing here doesn't add that much value...

@emanuelb
Copy link
Author

it does (if signed by bot account) as if signing used it avoid depending on Github SSL connection (as they / MITM can't sign the repo) as it daily it better be signed by bot and not user...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants