From 28d77b8e4eed27b44be9bc797940dab8b5a7eba2 Mon Sep 17 00:00:00 2001 From: Camden Narzt <6243207+CamJN@users.noreply.github.com> Date: Wed, 1 Jan 2025 06:02:15 -0700 Subject: [PATCH] Fix Clang 19 compilation (#2581) By dropping unused code. Fixes #2580. --- CHANGELOG | 1 + src/cxx_supportlib/Algorithms/MovingAverage.h | 6 ------ 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 6016cf0450..62641ae88a 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,6 +1,7 @@ Release 6.0.25 (Not yet released) ------------- * [Standalone] Changes Passenger (not app) start and stop timeouts to 25s (from 15s) except for Nginx engine mode, which retains a stop timeout of 60s. + * Fixes compilation with clang 19 (latest Fedora update) by dropping a buggy stddev function from the moving average header. Closes GH-2580. * diff --git a/src/cxx_supportlib/Algorithms/MovingAverage.h b/src/cxx_supportlib/Algorithms/MovingAverage.h index 19cbe48988..b646957d61 100644 --- a/src/cxx_supportlib/Algorithms/MovingAverage.h +++ b/src/cxx_supportlib/Algorithms/MovingAverage.h @@ -186,12 +186,6 @@ class DiscExpMovingAverageWithStddev { double stddev() const { return sqrt(sumOfSquaredData / dema.sumOfWeights - pow(average(), 2)); } - - double stddev(unsigned long long now) const { - DiscExpMovingAverageWithStddev copy(*this); - copy.update(0, now); - return sqrt(copy.sumOfSquaredData / copy.sumOfWeights - pow(copy.average(), 2)); - } };