Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reliable method of apk verification available #23

Open
sifr01 opened this issue Oct 27, 2022 · 1 comment
Open

No reliable method of apk verification available #23

sifr01 opened this issue Oct 27, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@sifr01
Copy link

sifr01 commented Oct 27, 2022

Here are three methods of apk download verification that would mitigate against MiTM attacks. It would be great if pia-foss/android could adopt at least one method for users to be able to verify their downloads:

  1. SHA256 fingerprint - signal messenger provide this verification method, here are the instructions on how to carry out the verification
  2. PGP signature with publication of public key - f-droid.org adopt this method of verification as do almost all major FOSS communities
  3. SHA checksum - this doesnt really offer protection from MiTM attacks but does provide basic verification against file corruption on download. It seems like all other PIA ports of the app provide this method except pia-foss/android.

As this is an obvious security vulnerability in the use of PIA's VPN app, please could this be resolved with priority?

@kp-juan-docal
Copy link
Contributor

kp-juan-docal commented Aug 30, 2023

hello @sifr01 it looks like with the design change we've mistakenly dropped the sha256 fingeprint section we had along with our web APK. I've created a ticket in our backlog to look into it.

@kp-juan-docal kp-juan-docal added the bug Something isn't working label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants