Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separte device specific implementations per device generation type #258

Open
Thaodan opened this issue Mar 15, 2023 · 1 comment
Open

Separte device specific implementations per device generation type #258

Thaodan opened this issue Mar 15, 2023 · 1 comment

Comments

@Thaodan
Copy link
Contributor

Thaodan commented Mar 15, 2023

Similar as done in Gadget bridge features such as notifications should be separated where possible.
For example right now the notification logic is specific to the first generation gadget bridge.

I saw some effort doing this already however I'm not sure if there was a generic bug for this topic.

@piggz
Copy link
Owner

piggz commented Apr 24, 2023

This sort-of exists already using the class hierarchy and overriding of methods. Later devices have certain features overridden.
The current hierarchy is basically GTR2 > GTS2 > GTS > Bip

Happy to accepts code-cleanups :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants