Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor suggestion: connect_to_wifi() should probably return the wlan object, rather than ip address. #46

Open
Nikorasu opened this issue Apr 4, 2023 · 0 comments

Comments

@Nikorasu
Copy link

Nikorasu commented Apr 4, 2023

This is just something I've been running into lately, in terms of usability.. There tends to be a lot of moments where I need a quick reference to the full wlan object, for access to various config options, and I've found the quickest solution was to just modify the connect_to_wifi function so it returns the full thing. Otherwise I end up not using connect_to_wifi, and miss out on the already setup loggin. heh
Edit: Just noticed one of the branches added a get_ip_address function for similar reasons. I prefer returning the whole object, so just gonna make my own fork, since I've done a lot of error handling too..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant