Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binded sql format error #11967

Closed
1 task done
whmmm opened this issue Jan 16, 2025 · 1 comment · Fixed by #11968
Closed
1 task done

binded sql format error #11967

whmmm opened this issue Jan 16, 2025 · 1 comment · Fixed by #11968
Assignees
@kojandy
Labels
bug module:web

Comments

@whmmm
Copy link

whmmm commented Jan 16, 2025

Prerequisites

Please check the FAQ, and search existing issues for similar questions before creating a new issue.YOU MAY DELETE THIS PREREQUISITES SECTION.

  • I have checked the FAQ, and issues and found no answer.

What version of pinpoint are you using?

pinpoint-server: 3.0.1
pinpoint-colloctor: 3.0.1-metric
pinpoint-agent: 2.5.4
pinpoint-web: 3.0.1-metric

Describe the bug

When viewing binded sql in Pinpoint web, an extra space is automatically added to the parameter.

For example:

In Pinpoint, it shows id=' 1821553006810529785',

but it should be id='1821553006810529785'.

Only the first parameter displays correctly.

What did you do to trigger the bug?

Expected behavior

Screenshots

Logs

Additional context
@kojandy kojandy self-assigned this Jan 16, 2025
kojandy added a commit to kojandy/pinpoint that referenced this issue Jan 16, 2025
@kojandy
[pinpoint-apm#11967] Skip leading space when binding values
4325b54
@kojandy kojandy mentioned this issue Jan 16, 2025
Merged
kojandy added a commit to kojandy/pinpoint that referenced this issue Jan 16, 2025
@kojandy
[pinpoint-apm#11967] Skip leading space when binding values
6058274
@kojandy
Copy link
Contributor

kojandy commented Jan 22, 2025

Thank you for reporting this issue. It will be fixed with the PR #11968.

kojandy added a commit that referenced this issue Jan 22, 2025
@kojandy
[#11967] Skip leading space when binding values
d31d099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kojandy kojandy

Labels
bug module:web
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#11967] Skip leading space when binding values kojandy/pinpoint
2 participants
@kojandy @whmmm