Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV_HANDLER][DOCS] Remove mention of PINGs being sent by Lowcar #164

Open
levincent06 opened this issue Jan 13, 2021 · 1 comment
Open
Assignees
Labels
code-cleanup Code health fixes/improvements documentation Improvements or additions to documentation oldies For Vincent, Daniel, and/or Ben

Comments

@levincent06
Copy link
Member

The only messages that Lowcar sends to Dev Handler are ACK, DEVICE_DATA, and LOG. Lowcar used to also send PINGs, but Dev Handler considers any incoming message as an online status message.

There may be some places in the code and documentation that suggest that dev handler can receive PINGs from Lowcar.

@levincent06 levincent06 added documentation Improvements or additions to documentation code-cleanup Code health fixes/improvements labels Jan 13, 2021
@levincent06 levincent06 self-assigned this Jan 13, 2021
@levincent06
Copy link
Member Author

This turned out to be a little more difficult than I thought because the virtual devices still send PINGs to dev handler. (Real Lowcar devices don't send PINGs.) Removing virtual device PINGs causes some devices to time out if more than 5 or so virtual devices try to connect.

Unsure why this is happening... my guess is that since each virtual device is a different process, the context switching is too slow and makes dev handler think the virtual devices time out.

@levincent06 levincent06 added the oldies For Vincent, Daniel, and/or Ben label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-cleanup Code health fixes/improvements documentation Improvements or additions to documentation oldies For Vincent, Daniel, and/or Ben
Projects
None yet
Development

No branches or pull requests

1 participant