Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NET_HANDLER] Work with Shepherd to implement hearbeat #208

Open
benliao1 opened this issue Apr 2, 2021 · 2 comments
Open

[NET_HANDLER] Work with Shepherd to implement hearbeat #208

benliao1 opened this issue Apr 2, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request high-priority Issues that should be fixed as soon as possible.
Milestone

Comments

@benliao1
Copy link
Collaborator

benliao1 commented Apr 2, 2021

Shepherd currently has some trouble detecting robot disconnects. They rely on Runtime cleanly exiting in the event of an emergency of some sort, and closing the server-side port. However, in some of these edge cases, Runtime isn't really able to close that socket well (ex. networking error / disconnect, robot shutdown because of low voltage, etc.). It would be easier to simply implement a heartbeat that is sent from Runtime to Shepherd periodically (maybe once per second or so) which would let Shepherd know that the robot is still alive and well.

@benliao1 benliao1 added enhancement New feature or request high-priority Issues that should be fixed as soon as possible. labels Apr 2, 2021
@benliao1 benliao1 added this to the 1.2 milestone Apr 2, 2021
@benliao1
Copy link
Collaborator Author

benliao1 commented Apr 2, 2021

This could probably be implemented as a TEXT protobuf that is sent with a timestamp or is blank or something, just a simple message saying "I'm alive!"

@benliao1 benliao1 self-assigned this Sep 24, 2021
@benliao1
Copy link
Collaborator Author

This will be implemented with the Runtime Status Message feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high-priority Issues that should be fixed as soon as possible.
Projects
None yet
Development

No branches or pull requests

2 participants