Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite timer types to use a class and not a dictionary #29

Open
FIREdog5 opened this issue Dec 26, 2020 · 3 comments
Open

Rewrite timer types to use a class and not a dictionary #29

FIREdog5 opened this issue Dec 26, 2020 · 3 comments
Assignees
Labels
back end a change to the back end of the code base easy issue Good for newcomers python Pull requests that update Python code

Comments

@FIREdog5
Copy link
Contributor

Ok, using a dictionary is just gross, lets use a class instead.. you would probably be able to cut down on the fields for the timer too, by having a constructor with a default function value, so NEEDS_FUNCTION would no longer be necessary. Modifications needed to at least Utils.py and Timers.py. Maybe this new class should just be declared in the Timers.py file?

@FIREdog5 FIREdog5 added easy issue Good for newcomers python Pull requests that update Python code back end a change to the back end of the code base labels Dec 26, 2020
@FIREdog5
Copy link
Contributor Author

It might be fun to add a timer_type.modify(header) method as well that would return a new timer_types instance with the same type, but a different header.

@FIREdog5
Copy link
Contributor Author

timer_type fields:
type
header

@FIREdog5
Copy link
Contributor Author

it might make things easier as well if support was added for an optional header_data field

@sberkun sberkun self-assigned this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back end a change to the back end of the code base easy issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

2 participants