Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts for WAIT commands #49

Open
FIREdog5 opened this issue May 27, 2021 · 2 comments
Open

Timeouts for WAIT commands #49

FIREdog5 opened this issue May 27, 2021 · 2 comments
Assignees
Labels
back end a change to the back end of the code base easy issue Good for newcomers feature New feature or request python Pull requests that update Python code

Comments

@FIREdog5
Copy link
Contributor

add a timeout for wait commands, after which the test will fail. Maybe set a default timeout and add an UNTIL option to WAIT?

@FIREdog5 FIREdog5 added feature New feature or request easy issue Good for newcomers python Pull requests that update Python code back end a change to the back end of the code base labels May 27, 2021
@FIREdog5
Copy link
Contributor Author

FIREdog5 commented Jun 3, 2021

ok, there are several parts to this:

  1. decide how to implement time outs:
    • spawn new thread for each WAIT and have these yield to the events queue
    • use the queue.get(block = True, timeout = <shortest>) and recalculate the timeout whenever an event is gotten from the queue.
      • theoretically cleaner
      • might make part 3 harder
  2. decide how to specify timeouts
    • a global timeout statement, and individual timeout commands for WAITs?
  3. write a system to detect when chained waits timeout. (This is kinda the opposite of when we decide to move on)
    • for OR, both must time out
    • for AND, just one must time out
    • can maybe exploit python's ands and ors, but inverting the inputs? not (not timedout or not timedout) would work for the or

@FIREdog5
Copy link
Contributor Author

FIREdog5 commented Jun 3, 2021

  1. using queue.get's timeout's
  2. global timeouts only.
  3. skip this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back end a change to the back end of the code base easy issue Good for newcomers feature New feature or request python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

1 participant