Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Travis CI Link Checking #264

Open
scottnuma opened this issue Sep 30, 2016 · 4 comments
Open

Travis CI Link Checking #264

scottnuma opened this issue Sep 30, 2016 · 4 comments

Comments

@scottnuma
Copy link
Contributor

We don't usually have (m)any broken links, but having automated checking for them might be nice - especially if external links break.

This article outlines how to do that. I'll try playing around with it on some test sites.

May or may not be worth the delay in pull request merging.

@scottnuma scottnuma self-assigned this Sep 30, 2016
@jiangdaniel
Copy link
Contributor

In regards to the delay in merging, we don't have to make the Travis CI check required for merging. We have the option to merge even without passing the Travis CI check.

@viviehn
Copy link
Contributor

viviehn commented Oct 10, 2016

Can/should we write a test for unclosed divs and other tags etc?

@scottnuma
Copy link
Contributor Author

scottnuma commented Oct 10, 2016

ah so update - I've got it working with my own website.

It works by running a library called html proofer on the content of the folder. HTML proofer can check a lot of things like unclosed tags, broken links, images w/o alt tags, etc. It can also be run outside of travis via command line too. It's pretty cool.

I have tried minor tests with my fork of the website - hitting roadblocks with a certain library needing a more current version of Ruby. Docker also isn't playing well with the expanded Gemfile - not sure yet with Vagrant. Probably would be good to ask DevOps for help in setting this up.

tbh, kind of a lot of work for something that will provide not that much utility after the first time we pass all the tests - however, it will help write more solid code and keep us accountable with that.

@viviehn viviehn changed the title Travis CL Link Checking Travis CI Link Checking Nov 14, 2016
@scottnuma
Copy link
Contributor Author

More evidence for link / syntax checking - commit #245

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants