Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not restart piped after reboot local k8s cluster (minikube) #5609

Open
mehboobpatel opened this issue Feb 27, 2025 · 4 comments
Open
Labels
kind/enhancement New feature or request

Comments

@mehboobpatel
Copy link

Image

Hello Devs,

I am starting with pipecd i followed quickstart documentation and created the piped deployment in my local minikube but when i restarted my system and started minikube again the piped deployment was failing if the control pane remains persistent than why not the piped deployment as i have to again do the process of creation s/piped.yaml|
sed -e 's/<YOUR_PIPED_ID>/66ed2/g'
-e 's/<YOUR_PIPED_KEY_DATA>/azRjYW9yNzFvMXVrNHmV6djNwbXlnNzk=/g' |
kubectl apply -n pipecd -f -

@mehboobpatel mehboobpatel added the kind/enhancement New feature or request label Feb 27, 2025
@t-kikuc
Copy link
Member

t-kikuc commented Feb 27, 2025

@mehboobpatel

Hi, thank you for reporting.
Would you please describe in the following format so that we can easily understand your situation? (Bug Report template)

**What happened**:

**What you expected to happen**:

**How to reproduce it**:

**Environment**:
- `piped` version:
- `control-plane` version:
- Others:

@khanhtc1202
Copy link
Member

khanhtc1202 commented Feb 27, 2025

Hi @mehboobpatel, If you can inspect the piped pod log (using kubectl logs or similar tools), maybe we can have more information to understand what's actually going on.

For now, my only guess is, since you're using quickstart installation mode, all of the pipecd control plane components (including the datastore) are just the containers running in minikube cluster. This means after you restart those containers, the registered information for the piped (ID and access key) is invalid. Via the control plane UI, you can check whether the registered piped is still valid or not by visiting the setting/piped page.

You have to:

Please note that this instruction is just for Quickstart. We think that not everyone wants to persist in the datastore to the host, so we didn't update the Quickstart manifest anyway.

@mehboobpatel
Copy link
Author

Image

Image <---here is the logs , you are right this point is correct This means after you restart those containers, the registered information for the piped (ID and access key) is invalid. Via the control plane UI, you can check whether the registered piped is still valid or not by visiting the setting/piped page. <-- but dont you think that it would be better if the piped deployment persists by default like the developer doesnt have to update the datastore container to persist the data to your host.

@khanhtc1202
Copy link
Member

khanhtc1202 commented Feb 28, 2025

@mehboobpatel it's a fair question 🙂
What is your plan to make that possible? Last time we thought about that, there were only two approaches:

The (2) approach is quite difficult, and I'm not yet checking approach (1) carefully. We need to test each environment carefully to support different cluster platforms (minikube, docker4mac, kind, etc.). As I mentioned, not everyone wants to persist data on their host. If you have any better idea to resolve this, we can discuss it here :)

On the other hand, this is a quickstart. If you want to set up an environment for dev, I prefer to follow this contribution guideline instead. It's also preferred to restart the preparation process each time you change the code (of the controlplane). wdyt?

@khanhtc1202 khanhtc1202 changed the title Regarding Piped deployment crashback Could not restart piped after reboot local k8s cluster (minikube) Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants