Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the behaviour of the Comment Poll #233

Open
viktorsmari opened this issue Sep 2, 2019 · 0 comments
Open

Change the behaviour of the Comment Poll #233

viktorsmari opened this issue Sep 2, 2019 · 0 comments

Comments

@viktorsmari
Copy link
Member

viktorsmari commented Sep 2, 2019

Problem:
All comments are polled every 3 seconds from the /api/.
They are always re-rendered, no matter what.

  • This is annoying if you are reading a comment that can be scrolled sideways.
  • This is annoying if you are trying to select / highlight text, in order to copy it.

Screenshot:
2019-09-02_09-13-35

Video:
https://imgur.com/a/5pAs3oK

How to reproduce:
Try reading the first comment and scroll it sideways. https://x.piratar.is/polity/1/issue/408/
Try highlighting any text in comment and wait 2-3 seconds.

Possible solutions:
Only re-render comments that have changed, or are new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant