-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Ability to cycle between the tab group only #3324
Comments
Do you mean following?: Tabs:
Cycling as B => C => D => E => B => C => ... when the topic 1 is focused. |
I was thinking it would be more like: (OP might have another view) Going down might be: <anything in topic 1> => F => K (assuming K was Topic 3) I actually wrote an addon today as it seemed fairly interesting. (Waiting on AMO approval - https://github.com/irvinm/Parent-Tab-Switcher) It works well with normal tabs, but am seeing some strangeness with TST Group Tabs and how it is assigned its openerTabID and if it gets updated or not when the tab is moved. (Everything looks fine with the tab properties with TST, but this addon shouldn't need to rely on anything from TST but only the openerTabID) Example: Starting point with some random tabs, you can see there are 5 tabs at the root and only 5 tabs that have undefined openerTabID ... good. Now I duplicated (Shift+Reload tab) "Group 3" to "NEW" and then dragged it to the root. In this case everything is the same except for the new tab but as it is still assigned a openerTabID, and thus it won't be selected to be switched to and it gets skipped over. Here is what it looks like live just going from bottom to top and back: 2023-04-22_17-19-18.mp4I will say this issue goes away after restarting the browser, so it might be an issue with Firefox and\or the current Developer's Edition version. After the AMO approves it, I will experiment more with the current version of FF. |
@piroor ... nevermind. This issue also happens with normal tabs and Firefox special tabs. It is not TST specific. I'll dig into it more. Strange that it resolves itself after a browser restart. |
Ok, irony at its best ... this looks related to a bug you opened 6 six years ago. (https://bugzilla.mozilla.org/show_bug.cgi?id=1409262) Maybe even more ironic that someone said they were going to be working on that issue and were assigned 4 months ago. (However, this does mean that this new addon would require TST to be installed to ensure that openerTabID gets updated as needed ... and that the defect would need to be resolved in order to work real-time) |
@piroor Yes. I meant something like this. Or it can also include the parent tab of the current tab during cycling. So for Topic 1. Cycling as A => B => C => D => E => A => B => C =>
when cyclic like this there will be a need to jump to another topic. This was my second point about
This is the part @irvinm is working on. It looks cool. Essentially, The feature I am looking for is scoping the tab cycling within the current topic and jump to topics all using keyboard shortcuts. |
Thank you for more descriptions. It does not match to your idea but I've realized that "focus previous sibling" and "focus next sibling" commands do not cycle focus, so I've fix the restriction with the commit cfb4227. Now you can cycle focus between tabs as: B => D => E => B ... This change should help you to move focus at your use case. |
Awesome! I already have key bindings for next-sibling and prev-sibling so this going to come in handy. In this regard, I am looking for two ways of cycling. "focus next parent", "focus previous parent" When advancing within a parent through sibling and children while at the last tab for the parent (top level tab). Jump to parent or first child. Basically cycle within the parent. |
Implementation wise this feature can be called as "focus mode" or something. This can be like pinning. When focus mode is enabled tabbing cycles within the parent and when it is turned off tabbing continues to next parent like usual. |
I am not exactly sure what the consensus is on the potential solution, but I'd like to see keystrokes for 'next sibling'/'previous sibling' and 'parent tab' ('child tab' is already handled by |
@piroor I think we can probably close this one. I had published the work I had done for being able to traverse parent tabs if anyone wants it. |
@irvinm Wow! Thanks, I've added it to the list of known helper addons. |
With tree style tabs I have tabs like
Here tabs within Topic 1 and Topic 2 are related to each other. So cycling between only those topics will be great for the workflow and to keep web browsing in context.
For this feature to work. There can be a customization option to
ctrl+tab
andctrl+shift+tab
only within a root parent.ctrl+shift+n
andctrl+shfit+p
The text was updated successfully, but these errors were encountered: