Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Duplicate of #3655] Group tab overview not working anymore #3660

Closed
marekhanzlik opened this issue Nov 11, 2024 · 2 comments
Closed
Labels

Comments

@marekhanzlik
Copy link

Abstract

When you click the group tab, normally you see new page with the list of all children. This stopped working.
Now there is just a loading icon and never finishes loading

Steps to reproduce

Don't have any

Expected result

Show the list of children tabs

Actual result

Just a loading icon is shown indefinetely

It looks like it crashes in file group-tab.js::274 on function window.l10n.updateDocument();. Because of unhandled exception, execution of remaining code is skipped.

Errors that pop up in console

l10s: apply title="__MSG_groupTab_options_dismiss__"
baseURI: "moz-extension://80bd9745-8010-4512-8035-2a9f72ffe0a6/resources/group-tab.html?title=ToRead"
childNodes: NodeList []
  length: 0
  <prototype>: NodeListPrototype { item: item(), keys: keys(), values: values(), … }
firstChild: null
isConnected: false
lastChild: null
localName: "title"
name: "title"
namespaceURI: null
nextSibling: null
nodeName: "title"
nodeType: 2
nodeValue: "Dismiss this hint"
ownerDocument: HTMLDocument moz-extension://80bd9745-8010-4512-8035-2a9f72ffe0a6/resources/group-tab.html?title=ToRead
ownerElement: <button id="dismissOptionHint" title="Dismiss this hint">
parentElement: null
parentNode: null
prefix: null
previousSibling: null
specified: true
textContent: "Dismiss this hint"
value: "Dismiss this hint"
<prototype>: AttrPrototype { localName: Getter, value: Getter & Setter, name: Getter, … }
l10n-classic.js:19:15


Error: tab.favIconUrl is null

Environment

  • Platform (OS): Ubuntu
  • Version of Firefox: 132.0.1
  • Version (or revision) of Tree Style Tab: 4.0.24
@irvinm
Copy link
Contributor

irvinm commented Nov 11, 2024

Duplicate of #3655. (Fixed already in dev builds)

@marekhanzlik
Copy link
Author

marekhanzlik commented Nov 11, 2024

Sorry for duplicate, looks like my search skills are poor :(
Closing, thanks for the fix!

@marekhanzlik marekhanzlik changed the title [Bug] Group tab overview not working anymore [Bug] [Duplicate of #3655] Group tab overview not working anymore Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants