-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang 16 (c++20) build in CI fails #577
Comments
Looks like this problem may be building OK and now it is a timeout issue?
Ref: https://github.com/pisa-engine/pisa/actions/runs/12653075572/job/35257363391#step:4:40145 |
Yes, I believe the problem is the build with sanitizers on. Because of the sanitizers, it executes slowly. I've been thinking of using a smaller collection for these tests, but haven't had the time to look into it yet. |
Ok thanks good to know we can probably use smaller collection fixtures and the timeout may be because ASAN, etc. |
The compression test runs for each encoding to verify that collection builds without an error. Additionally, we run a test with sanitizers enabled, which can find memory issues, etc. This tests is very slow, however, so making it a smaller collection helps with the timeouts. Fixes: #577 Signed-off-by: Michal Siedlaczek <[email protected]>
The compression test runs for each encoding to verify that collection builds without an error. Additionally, we run a test with sanitizers enabled, which can find memory issues, etc. This tests is very slow, however, so making it a smaller collection helps with the timeouts. Fixes: #577 Signed-off-by: Michal Siedlaczek <[email protected]>
@lgrz I pushed a change that uses a very small collection for this particular test. Hopefully that helps. I tagged you as a reviewer. |
Thanks @elshize will take a look |
The compression test runs for each encoding to verify that collection builds without an error. Additionally, we run a test with sanitizers enabled, which can find memory issues, etc. This tests is very slow, however, so making it a smaller collection helps with the timeouts. Fixes: #577 Signed-off-by: Michal Siedlaczek <[email protected]>
Fixed 🎉 |
Clang 16 (c++20) build in CI fails:
https://github.com/pisa-engine/pisa/actions/runs/7865449374/job/21458386783
The text was updated successfully, but these errors were encountered: