Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang 16 (c++20) build in CI fails #577

Closed
elshize opened this issue Feb 12, 2024 · 6 comments · Fixed by #600
Closed

Clang 16 (c++20) build in CI fails #577

elshize opened this issue Feb 12, 2024 · 6 comments · Fixed by #600
Labels
bug Something isn't working

Comments

@elshize
Copy link
Member

elshize commented Feb 12, 2024

Clang 16 (c++20) build in CI fails:

https://github.com/pisa-engine/pisa/actions/runs/7865449374/job/21458386783

65.16 -- Compiling and running to test HAVE_POSIX_REGEX
65.20 -- Performing Test HAVE_POSIX_REGEX -- failed to compile
@elshize elshize added the bug Something isn't working label Feb 12, 2024
@lgrz
Copy link
Collaborator

lgrz commented Feb 1, 2025

Looks like this problem may be building OK and now it is a timeout issue?
Noting this for future reference. The build logs below are from 55b3c3c.

...
2025-01-07T14:45:23.2139306Z 23: [2025-01-07 14:45:23.210] [info] number of elements / number of blocks: 21.398842
2025-01-07T14:45:23.2454649Z 23: [2025-01-07 14:45:23.244] [info] Processing 10000 documents
2025-01-07T14:45:29.3016542Z 123/123 Test  #23: test_compress:Compress quantized index ..................................................................***Timeout 1500.07 sec
2025-01-07T14:45:29.3070292Z 
2025-01-07T14:45:29.3072197Z Errors while running CTest
2025-01-07T14:45:29.3072753Z 99% tests passed, 1 tests failed out of 123
2025-01-07T14:45:29.3073228Z 
2025-01-07T14:45:29.3073439Z Total Test time (real) = 1571.92 sec
2025-01-07T14:45:29.3073860Z 
2025-01-07T14:45:29.3074058Z The following tests FAILED:
2025-01-07T14:45:29.3074734Z 	 23 - test_compress:Compress quantized index (Timeout)
2025-01-07T14:45:29.4548267Z ##[error]Process completed with exit code 8.

Ref: https://github.com/pisa-engine/pisa/actions/runs/12653075572/job/35257363391#step:4:40145

@elshize
Copy link
Member Author

elshize commented Feb 2, 2025

Yes, I believe the problem is the build with sanitizers on. Because of the sanitizers, it executes slowly. I've been thinking of using a smaller collection for these tests, but haven't had the time to look into it yet.

@lgrz
Copy link
Collaborator

lgrz commented Feb 2, 2025

Ok thanks good to know we can probably use smaller collection fixtures and the timeout may be because ASAN, etc.

elshize added a commit that referenced this issue Feb 15, 2025
The compression test runs for each encoding to verify that collection
builds without an error. Additionally, we run a test with sanitizers
enabled, which can find memory issues, etc. This tests is very slow,
however, so making it a smaller collection helps with the timeouts.

Fixes: #577

Signed-off-by: Michal Siedlaczek <[email protected]>
elshize added a commit that referenced this issue Feb 15, 2025
The compression test runs for each encoding to verify that collection
builds without an error. Additionally, we run a test with sanitizers
enabled, which can find memory issues, etc. This tests is very slow,
however, so making it a smaller collection helps with the timeouts.

Fixes: #577

Signed-off-by: Michal Siedlaczek <[email protected]>
@elshize
Copy link
Member Author

elshize commented Feb 15, 2025

@lgrz I pushed a change that uses a very small collection for this particular test. Hopefully that helps. I tagged you as a reviewer.

@lgrz
Copy link
Collaborator

lgrz commented Feb 16, 2025

Thanks @elshize will take a look

elshize added a commit that referenced this issue Feb 18, 2025
The compression test runs for each encoding to verify that collection
builds without an error. Additionally, we run a test with sanitizers
enabled, which can find memory issues, etc. This tests is very slow,
however, so making it a smaller collection helps with the timeouts.

Fixes: #577

Signed-off-by: Michal Siedlaczek <[email protected]>
@elshize
Copy link
Member Author

elshize commented Feb 18, 2025

Fixed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants