Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product stock not updated ? #1

Open
kreare opened this issue Nov 9, 2024 · 2 comments
Open

Product stock not updated ? #1

kreare opened this issue Nov 9, 2024 · 2 comments

Comments

@kreare
Copy link

kreare commented Nov 9, 2024

I'm testing this module but looks like that product stock for ordered products are not updated, if customer choose CoD as payment method.

Are you aware of this ?

@kreare
Copy link
Author

kreare commented Nov 9, 2024

Issue seems here:

        if ($order_status->logable && number_format($cart_total_paid + $fee_tax_incl, $computingPrecision) != number_format($amount_paid, $computingPrecision) ) {
            $id_order_state = Configuration::get('PS_OS_ERROR');
        }

$amount_paid doesn't contain the fee, so the comparison would never succeed.

@kreare
Copy link
Author

kreare commented Nov 9, 2024

As payment is done after delivery, customers didn't pay anything online, so probably that check is useless, or probably we shoul sum the fee to $amount_paid too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant