Refactor styles.scss

[paperdigits]

Now that we have that sweet, sweet sass, we should make sure all the classes are nice and clean and get maximum reuse out of our sass!

[paperdigits]

@patdavid I wanted to get rid of the individual index.css files in each article (articles for now, since apparently index.css are in several places), and use the stylesheet field in the article metadata to specify the name of a class you want to hook into with CSS.

So in the index.md for the article, you'd have:

---
title: Some Title
author: A. Guy
stylesheet: some-title-unique-string
---

Then in a SASS file, you'd have:

.some-title-unique-string {
border-top: 24em;
background: blue;
}

That way we could have one SASS file for all the extra article CSS.

I think that'd help us consolidate and it'd cut back the number of calls to the web server.

What do you think of that?

I had originally thought we had a page slug in there that was a unique string that represented the article, but apparently we're doing that with the folder name.

[patdavid]

I like it! Lets us deal with oddball style cases as needed which is nice. I'd say go for it.

Though - we should check that it's really even needed still for most pages. I thought I had started cleaning out posts that used specific stylesheets in order to support this. It might be that most articles don't even have unique stylesheet needs anymore...

[paperdigits]

There are a handful or two of articles that still have an index.CSS file. Some of them look like they can be generalized and moved into the main style.scss file, and the others I'll add the class to. Then I'll move onto the other pages.

…

On December 28, 2016 8:16:01 AM PST, Pat David ***@***.***> wrote: I like it! Let's us deal with oddball style cases as needed which is nice. I'd say go for it. Though - we should check that it's really even needed still for most pages. I thought I had started cleaning out posts that used specific stylesheets in order to support this. It might be that most articles don't even have unique stylesheet needs anymore... -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #32 (comment)

[paperdigits]

@patdavid can you check out the sass-class-slug branch? I think I've gotten rid of all the index.css files without breaking the site. Unfortunately, I don't have backstop.js setup anymore :( I need to redo that.

[patdavid]

I'll pull it down later today and test it against a backstop image.

[paperdigits]

@patdavid let me know what happened with the sass-class-slug branch when you have a moment!

[patdavid]

I had backstop tests running last week, then got sidetracked into editing a GIMP news article/interview. I'll make sure it's the first thing I try as soon as I get home.

On Mon, Feb 27, 2017 at 1:25 AM Mica ***@***.***> wrote: @patdavid <https://github.com/patdavid> let me know what happened with the sass-class-slug branch when you have a moment! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACpnMHfk1zQ5OFhu1qU7UKGEivw5reKsks5rgmxdgaJpZM4Km5KK> .

-- Pat David https://patdavid.net GPG: 66D1 7CA6 8088 4874 946D 18BD 67C7 6219 89E9 57AC