-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: automatically PR meeting minutes once meeting has concluded #10
Comments
Maybe this could be a separate Action (separation of concerns)? |
It definitely could be! It would potentially be nice to have an all-in-one that reduces the overhead of configuration and setup for folks trying to ramp up to the tooling and just get going, but I could conceive of reasons to have it be separate. |
I guess I'd be fine with it being implemented either way :) |
I would also be fine with it being implemented either way - if someone's willing to do the work, whatever they're willing/able to do is a +1 from me :) |
I'm sorta looking into it, although I'm writing an example using HackMD instead of Google Drive (I suggested we try out HackMD on nodejs/diagnostics). One thing we would need to decide is how to fetch the meeting issue and how to find the meeting link in the issue. We could either use a heuristic approach (search issues by title name and chose the most recently opened meeting + search the issue body for "Minutes: .*"), or we could have explicit identifiers to make things easier (have a label Another thing we can do as a part of this feature is to add the recording link to the minutes (which has similar challenges as suggested above, plus finding the recording which I think is harder than finding an issue). |
I'm in favor of the label approach since it also provides a good way for humans to identify which meeting issue is the one they should be looking at (some repos are slow to close old meeting issues and the title system is not currently very helpful). @mmarchini could you explain the metadata comment a bit more to me? I don't totally understand. I do get the placeholder part but I don't understand how it's relevant to the labeling. Also, I would prefer that we ensure that we're doing placeholders extremely consistently and - at least if we're going how things currently work - in a way that we can simplify later, if we're going to go down that approach in the templates. |
I think placeholder is a better word than metadata for what I meant. Basically, instead of having: ## Links
* **Recording**:
* **GitHub Issue**: https://github.com/nodejs/diagnostics/issues/397
* **Minutes Google Doc**: https://docs.google.com/document/d/14W5g4rHw38XzX1wGYgCOSXY-v7AW0_jw_b2IcctnGKM/edit We would have ## Links
* **Recording**: <!-- recording-placeholder -->
* **GitHub Issue**: https://github.com/nodejs/diagnostics/issues/397
* **Minutes Google Doc**: https://docs.google.com/document/d/14W5g4rHw38XzX1wGYgCOSXY-v7AW0_jw_b2IcctnGKM/edit
<!-- minutes:https://docs.google.com/document/d/14W5g4rHw38XzX1wGYgCOSXY-v7AW0_jw_b2IcctnGKM/edit --> Since |
Another feature that may be potentially useful and completely solve this: https://hackmd.io/c/tutorials/%2Fs%2Flink-with-github |
Right, as long as we don't require PRs for minutes it should work. Reading the comments it I wonder how well it would work with several folks making changes to the minutes and trying to push (because users need to push and pull manually). Also, seems like this feature requires users to manually link the minute every time (unless there's an API for that, which I don't think there is yet). Worth keeping an eye on this feature, they might add improvements to it in the future :) |
cc @joesepi this is the issue for the feature you want, by the way. Would genuinely love to see a PR around this - shouldn't be massively complex ❤️ |
At present there's several manual steps of automatically PR'ing in the meeting minutes. Need to copy from Google Docs, create a new file in the repo with the correct title structure (currently, most repos use the date of the meeting as the filename) in the correct directory, and submit a PR. This is a process that unnecessarily uses human time that could be used elsewhere for more productive things.
It would be excellent if meet could automatically PR any meeting minutes for meetings that have already completed but have not yet been PR'ed.
The text was updated successfully, but these errors were encountered: