Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable release bundling on PR branches #14

Open
bnb opened this issue May 4, 2020 · 0 comments
Open

Enable release bundling on PR branches #14

bnb opened this issue May 4, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bnb
Copy link
Contributor

bnb commented May 4, 2020

Currently it seems that there's no possibility to actually test PRs since the release.yml GitHub Action only runs on release, meaning that node_modules is not included in PR branches. As such, to actually be able to test you need to create a release which seems less than ideal 😅

It seems that mirroring that GitHub Action and running it on PRs in branches that aren't master is a potential solution.
@github-actions github-actions bot mentioned this issue Oct 9, 2020
Closed
@github-actions github-actions bot mentioned this issue Oct 26, 2020
Closed
@wesleytodd wesleytodd added enhancement New feature or request good first issue Good for newcomers labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnb @wesleytodd