Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon will accept any trailing characters to a command (before / delimeter) #141

Open
pkoutoupis opened this issue Dec 17, 2022 · 1 comment
Assignees
Labels

Comments

@pkoutoupis
Copy link
Owner

Original command:

petros@dev-machine:~/misc/rapiddisk/src$ curl -s --output - 10.0.0.185:9118/v1/listAllNVMePorts|jq .
{
  "targets": [
    {
      "nvmet_ports": [
        {
          "port": 1,
          "address": "10.0.0.185",
          "protocol": "tcp"
        }
      ]
    }
  ]
}

Trailing characters:

petros@dev-machine:~/misc/rapiddisk/src$ curl -s --output - 10.0.0.185:9118/v1/listAllNVMePortssssd|jq .
{
  "targets": [
    {
      "nvmet_ports": [
        {
          "port": 1,
          "address": "10.0.0.185",
          "protocol": "tcp"
        }
      ]
    }
  ]
}
@pkoutoupis pkoutoupis added the bug label Dec 17, 2022
@pkoutoupis pkoutoupis self-assigned this Dec 17, 2022
@matteotenca
Copy link
Collaborator

There is no strict checking on URL syntax, in general. I introduced some checks on the number of arguments of some REST calls, but more sanity checks are needed. More on this as soon as I can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants