Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native XML Export/Import is not handling internal review round correctly #10606

Open
jardakotesovec opened this issue Nov 14, 2024 · 1 comment
Assignees
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Milestone

Comments

@jardakotesovec
Copy link
Contributor

jardakotesovec commented Nov 14, 2024

Describe the bug
While debugging e2e tests - it turned out that export/import test is corrupting data and results in submission which is in internal review (OMP), but without review round created - which is always expected to be there and therefore it crashes at least in one place..

Test is temporarily disabled. Its not easy to pin point if its long standing bug or regression, as this test was disabled for some time - #10115 . And the crash is coming from the new code in submission listing.

To Reproduce
Steps to reproduce the behavior:

  1. Run MsmithSubmission.cy.js test
  2. Re-enable the Import test in NativeXmlImportExportSubmission.cy.js and run it
  3. Check the data structure - its missing review round, which is crashing new submission listing

Tested only in 3.5. Once investigated, it might be good to check the older versions if they might be affected by this.

What application are you using?
OJS, OMP or OPS version 3.5

Additional information
Here is crash stack trace when rendering new submission listing. It fails, because it assume that there is always review round for active stage.

[Wed Nov 13 15:47:06 2024] 127.0.0.1:44570 [500]: GET /index.php/publicknowledge/api/v1/_submissions?status=1&offset=0&count=30&page=1&perPage=30
[Wed Nov 13 15:47:06 2024] 127.0.0.1:44570 Closing
[Wed Nov 13 15:47:06 2024] 127.0.0.1:44578 Accepted
[Wed Nov 13 15:47:07 2024] Error: Call to a member function getId() on null in /home/runner/omp/classes/submission/maps/Schema.php:183
Stack trace:
#0 /home/runner/omp/lib/pkp/classes/submission/maps/Schema.php(654): APP\submission\maps\Schema->getAvailableEditorialDecisions()
#1 /home/runner/omp/lib/pkp/classes/submission/maps/Schema.php(393): PKP\submission\maps\Schema->getPropertyStages()
#2 /home/runner/omp/classes/submission/maps/Schema.php(65): PKP\submission\maps\Schema->mapByProperties()
#3 /home/runner/omp/lib/pkp/classes/submission/maps/Schema.php(250): APP\submission\maps\Schema->mapByProperties()
#4 /home/runner/omp/lib/pkp/classes/submission/maps/Schema.php(285): PKP\submission\maps\Schema->mapToSubmissionsList()
#5 /home/runner/omp/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Collections/LazyCollection.php(779): PKP\submission\maps\Schema->PKP\submission\maps\{closure}()
#6 /home/runner/omp/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Collections/LazyCollection.php(1707): Illuminate\Support\LazyCollection->Illuminate\Support\{closure}()
#7 [internal function]: Illuminate\Support\LazyCollection->Illuminate\Support\{closure}()
#8 /home/runner/omp/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Collections/LazyCollection.php(106): iterator_to_array()
#9 /home/runner/omp/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Collections/Traits/EnumeratesValues.php(964): Illuminate\Support\LazyCollection->all()
#10 [internal function]: Illuminate\Support\LazyCollection->jsonSerialize()

@jardakotesovec
Copy link
Contributor Author

jardakotesovec commented Nov 14, 2024

Temporarly disabled 2 doi tests in OJS and OPS, as these were impacted by disabling import/export in pkp-lib.

jardakotesovec added a commit to pkp/ops that referenced this issue Nov 14, 2024
@withanage withanage self-assigned this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Projects
None yet
Development

No branches or pull requests

2 participants