Announcement desc toolbar missing image code and lists

[salmanm2003]

I have noticed that the toolbar for the Announcement Description and Short Description fields lacks features for adding images, viewing content code, and creating lists.

Steps to reproduce the behavior:

1. Go to 'Announcements'
2. Click on 'Add announcement'
3. Scroll down to 'Description and Short description
4. The toolbar for both fields is missing options to add images, create lists, and view the content code.

What application are you using?
OJS 3.3.0-20

Additional information
I have submitted a pull request to add these features to the toolbars. Here is the link:#10827

[asmecher]

Thanks, @salmanm2003, that looks good; can you forward-port to stable-3_4_0 and main?

[salmanm2003]

Hi @asmecher, I’ve submitted the three PRs as requested. Could you please review them and let me know if there are any issues?

[asmecher]

Thanks, @salmanm2003 -- I've merged the PRs to stable-3_3_0 and stable-3_4_0, but #10848 needs a rebase to resolve a merge conflict. Could you have a look?

[bozana]

Hi @asmecher and @salmanm2003,
Could it be that these changes broke the administration site settings page in stable-3_4_0? -- PKPAnnouncementForm now expects more arguments in the constructor, which has not be adapted in AdminHandler.
I get this error message:
PHP message: PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function PKP\\components\\forms\\announcement\\PKPAnnouncementForm::__construct(), 4 passed in /.../lib/pkp/pages/admin/AdminHandler.php on line 209 and exactly 6 expected in /.../lib/pkp/classes/components/forms/announcement/PKPAnnouncementForm.php:49\nStack