Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing foreign key declarations #8826

Closed
2 of 6 tasks
asmecher opened this issue Mar 17, 2023 · 4 comments
Closed
2 of 6 tasks

Add missing foreign key declarations #8826

asmecher opened this issue Mar 17, 2023 · 4 comments
Assignees
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Milestone

Comments

@asmecher
Copy link
Member

asmecher commented Mar 17, 2023

Several foreign key constraints were missed in the introduction of #6093. Add them:

  • filters.context_id
  • plugin_settings.context_id
  • navigation_menus.context_id
  • navigation_menu_items.context_id
  • user_groups.context_id
  • email_log.sender_id
@asmecher asmecher added the Bug:2:Moderate A bug that is causing problems for a substantial minority of users. label Mar 17, 2023
@asmecher asmecher added this to the 3.5 milestone Mar 17, 2023
@bozana
Copy link
Collaborator

bozana commented Aug 16, 2023

I am not sure if it belongs here, but: submission_file_settings contain chapterId setting_name (in OMP). This chapter IDs could apparently be orphaned, not exist any more in the table submission_chapters. S. the case here #9186.

@bozana
Copy link
Collaborator

bozana commented Aug 25, 2023

Here an update to the situation described above, when submission files exist with not existing chapter IDs (s. #9186 (comment)): in this case the submission files do exist and are listed and approved under Publication > Publication Formats. Removing the entries with not existing chapter IDs from the table submission_file_settings would lead to publicly listing of those files on the book view page (from previously not being listed), which could be an undesired effect. Thus, maybe the solution here is to just check and report such cases during the upgrade preflight check, so that users can resolve them manually.

@defstat defstat self-assigned this Mar 6, 2024
asmecher added a commit to asmecher/pkp-lib that referenced this issue May 8, 2024
asmecher added a commit to asmecher/ojs that referenced this issue May 8, 2024
@asmecher
Copy link
Member Author

asmecher commented May 8, 2024

asmecher added a commit to pkp/ojs that referenced this issue May 10, 2024
asmecher added a commit to pkp/omp that referenced this issue May 10, 2024
asmecher added a commit to pkp/ops that referenced this issue May 10, 2024
asmecher added a commit to pkp/ojs that referenced this issue May 10, 2024
asmecher added a commit to pkp/omp that referenced this issue May 10, 2024
@jonasraoni
Copy link
Contributor

I'm closing this as a duplicate of #8333, which has a couple of initial PRs.

@jonasraoni jonasraoni closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Projects
None yet
Development

No branches or pull requests

5 participants