New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port StageAssignmentDAO and StageAssignment to Eloquent Model #9674

Closed

defstat opened this issue Jan 31, 2024 · 14 comments

Assignees

Labels

Enhancement:2:Moderate

Contributor

defstat commented Jan 31, 2024 •

edited

Loading

Describe the change
Right now the StageAssignment entity is a DataObject and it follows the DAO pattern.

We will port StageAssignment entity and its respective DAO class, StageAssignmentDAO to Laravel's Eloquent Model.

What application will be affected?
OJS, OMP or OPS main branch
PKP supported/maintained plugins main branch

Additional information
Please add any screenshots, logs or other information we can use to investigate this bug report.

PRs

OJS: pkp/ojs#4166
OMP: pkp/omp#1510
OPS: pkp/ops#626
PKP-LIB: #9675

Plugins Issues and PRs

QuickSubmitPlugin - PR: [quickSubmit][main] #90 Replace StageAssignmentDAO quickSubmit#91

The text was updated successfully, but these errors were encountered:

defstat self-assigned this

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 Port StageAssignmentDAO and StageAssignment to Eloquent Model

91002da

defstat added a commit to defstat/ojs that referenced this issue


          pkp/pkp-lib#9674 Port StageAssignmentDAO and StageAssignment to Eloqu…

0d1a173

…ent Model

Contributor Author

defstat commented Jan 31, 2024 •

edited

Loading

@Vitaliy-1 this is a PR that removes StageAssignmentDAO and StageAssignment from the codebase in favor of a new StageAssignment Eloquent Model. If you have some time, could you review it, also in relation to your changes at #9589.

Are there things that we should consider adding or develop differently, in order to incorporate the needs of other works in progress?

defstat added a commit to defstat/omp that referenced this issue


          pkp/pkp-lib#9674 Port StageAssignmentDAO and StageAssignment to Eloqu…

0ae37c5

…ent Model

defstat added a commit to defstat/omp that referenced this issue


          pkp/pkp-lib#9674 Submodule update ##defstat/i9674##

4978c00

defstat added a commit to defstat/ops that referenced this issue


          pkp/pkp-lib#9674 Port StageAssignmentDAO and StageAssignment to Eloqu…

…ent Model

defstat added a commit to defstat/ops that referenced this issue


          pkp/pkp-lib#9674 Submodule update ##defstat/i9674##

0a65292

jonasraoni added the Enhancement:2:Moderate label

Collaborator

Vitaliy-1 commented Mar 4, 2024

@defstat, please let me know when this is merged so I can backport the changes to the #8885

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 Conflicts fixes

b79b2f0

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 Code Review Changes

27cca1d

defstat added a commit to defstat/ojs that referenced this issue


          pkp/pkp-lib#9674 Port StageAssignmentDAO and StageAssignment to Eloqu…

11c382d

…ent Model

defstat added a commit to defstat/ojs that referenced this issue


          pkp/pkp-lib#9674 Submodule Update ##defstat/i9674##

fbfcf43

Contributor Author

defstat commented Mar 5, 2024

@Vitaliy-1 thanks for the code review. I have resolved most of the comments and added 1-2 new comments for clarification. Because there are one-or-two review changes that may affect the tests, I am running the tests on OJS, and waiting for the clarifications on the review.

Collaborator

Vitaliy-1 commented Mar 14, 2024

Thanks, @defstat. It looks good! Regarding with...Id() vs with...Ids() methods, leaving it up to you

defstat mentioned this issue

In OJS, a reviewer cannot access his/her recommendations from a previous round. #9453

Closed

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 Merge Conflicts

bd79663

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 Code Review Changes

2e0d4bd

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 replaced scope functions taking one parameter with related f…

db6807c

…unctions taking array of parameters

defstat added a commit to defstat/ojs that referenced this issue


          pkp/pkp-lib#9674 Port StageAssignmentDAO and StageAssignment to Eloqu…

f688a1b

…ent Model

defstat added a commit to defstat/ojs that referenced this issue


          pkp/pkp-lib#9674 replaced scope functions taking one parameter with r…

7dfc6f0

…elated functions taking array of parameters

defstat added a commit to defstat/ojs that referenced this issue


          pkp/pkp-lib#9674 Submodule Update ##defstat/i9674##

d88ded9

defstat added a commit to defstat/omp that referenced this issue


          pkp/pkp-lib#9674 Port StageAssignmentDAO and StageAssignment to Eloqu…

a414322

…ent Model

defstat added a commit to defstat/omp that referenced this issue


          pkp/pkp-lib#9674 replaced scope functions taking one parameter with r…

d8b3edf

…elated functions taking array of parameters

defstat added a commit to defstat/omp that referenced this issue


          pkp/pkp-lib#9674 Submodule Update ##defstat/i9674##

5ee09b9

defstat added a commit to defstat/ops that referenced this issue


          pkp/pkp-lib#9674 Port StageAssignmentDAO and StageAssignment to Eloqu…

f1300d3

…ent Model

defstat added a commit to defstat/ops that referenced this issue


          pkp/pkp-lib#9674 replaced scope functions taking one parameter with r…

c9f244d

…elated functions taking array of parameters

defstat added a commit to defstat/ops that referenced this issue


          pkp/pkp-lib#9674 Submodule Update ##defstat/i9674##

6303bc8

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 Fix update model

9365ddb

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 replaced scope functions taking one parameter with related f…

34dc3d9

…unctions taking array of parameters

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 Fix update model

d16780f

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 Fix

c0b6717

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 Override the update function for stageAssignment updates

f016f71

defstat added a commit to defstat/pkp-lib that referenced this issue


          pkp#9674 Fix update clause

54e54ca

defstat added a commit to defstat/ojs that referenced this issue


          pkp/pkp-lib#9674 Port StageAssignmentDAO and StageAssignment to Eloqu…

54a6196

…ent Model

defstat added a commit to defstat/ojs that referenced this issue


          pkp/pkp-lib#9674 replaced scope functions taking one parameter with r…

8da7e21

…elated functions taking array of parameters

defstat added a commit to defstat/ojs that referenced this issue


          pkp/pkp-lib#9674 Submodule Update ##defstat/i9674##

a7e0250

defstat added a commit to defstat/omp that referenced this issue


          pkp/pkp-lib#9674 Port StageAssignmentDAO and StageAssignment to Eloqu…

006e79f

…ent Model

defstat added a commit to defstat/omp that referenced this issue


          pkp/pkp-lib#9674 replaced scope functions taking one parameter with r…

146b475

…elated functions taking array of parameters

defstat added a commit to defstat/omp that referenced this issue


          pkp/pkp-lib#9674 Minor Fix

7e2f695

defstat added a commit to defstat/omp that referenced this issue


          pkp/pkp-lib#9674 Submodule Update ##defstat/i9674##

b6e698c

defstat added a commit to defstat/ops that referenced this issue


          pkp/pkp-lib#9674 Port StageAssignmentDAO and StageAssignment to Eloqu…

ef7f311

…ent Model

defstat added a commit to defstat/ops that referenced this issue


          pkp/pkp-lib#9674 replaced scope functions taking one parameter with r…

c0e5334

…elated functions taking array of parameters

defstat added a commit to defstat/ops that referenced this issue


          pkp/pkp-lib#9674 Submodule Update ##defstat/i9674##

defstat added a commit that referenced this issue


          #9674 Resolve Conflicts

e5a7262

defstat added a commit that referenced this issue


          #9674 Code Review Changes

71d038a

defstat added a commit that referenced this issue


          #9674 replaced scope functions taking one parameter with related func…

3ff0147

…tions taking array of parameters

defstat added a commit that referenced this issue


          #9674 Fix update model

0d3224b

defstat added a commit that referenced this issue


          #9674 Fix

7905e44

defstat added a commit that referenced this issue


          #9674 Override the update function for stageAssignment updates

95758f6

defstat added a commit that referenced this issue


          #9674 Fix update clause

3cb57cd

defstat added a commit to pkp/ojs that referenced this issue


          Merge pull request #4166 from defstat/pkp/pkp-lib#9674

42d6fcc

[OJS][main] #9674 Port StageAssignmentDAO and StageAssignment to Eloquent Model

defstat added a commit to pkp/omp that referenced this issue


          Merge pull request #1510 from defstat/pkp/pkp-lib#9674

e42336b

[OMP][main] #9674 Port StageAssignmentDAO and StageAssignment to Eloquent Model

defstat added a commit to pkp/ops that referenced this issue


          Merge pull request #626 from defstat/pkp/pkp-lib#9674

2fbda9b

[OPS][main] #9674 Port StageAssignmentDAO and StageAssignment to Eloquent Model

Contributor Author

defstat commented Apr 25, 2024

@Vitaliy-1 @asmecher everything merged on pkp-lib, ojs, omp, ops.

Leaving it open for plugins

defstat mentioned this issue

StageAssignmentDAO removal - port to new StageAssignment Eloquent schema pkp/quickSubmit#90

Closed

Member

asmecher commented Jul 4, 2024

@defstat, is there still work required for this one?

Contributor Author

defstat commented Jul 5, 2024

@asmecher I have not yet gone through all plugins for making the necessary changes regarding this.

defstat closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment