Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invitations: API Support (Update Invitation and Add Invitation) + Change Profile Email Invitation #9887

Closed
9 tasks
defstat opened this issue Apr 15, 2024 · 2 comments
Closed
9 tasks

Invitations: API Support (Update Invitation and Add Invitation) + Change Profile Email Invitation #9887

defstat opened this issue Apr 15, 2024 · 2 comments
Assignees
@defstat
Milestone
3.5.0 LTS

Comments

@defstat
Copy link
Contributor

defstat commented Apr 15, 2024 •
edited
Loading

Describe the feature
There is a need to add certain features to the Invitations toolset.

  1. API Support
  • Update Invitation Payload
  • Accept Invitation
  • Decline Invitation
  • Dispatch invitation (Access rights should be considered)
  1. A new invitation for Change user Profile Email.
  • Ability to request an email change in the user profile page
  • A new mailable that will be send to the requested email, and will contain the "accept invitation url"
  • Message on the user profile page that there is already an email change request. Something like:
image
  • Disable the ability to request another email change if one is pending. Something like:
image
  • Ability to cancel the change request from within the profile page. Something like:
image

PRs

OJS: pkp/ojs#4244
PKP-LIB: #9888
@defstat defstat self-assigned this Apr 15, 2024
defstat added a commit to defstat/ojs that referenced this issue Apr 15, 2024
@defstat
pkp/pkp-lib#9887 API Support
6975720
defstat added a commit to defstat/pkp-lib that referenced this issue Apr 15, 2024
@defstat
pkp#9887 API Support
5318f3c
defstat added a commit to defstat/pkp-lib that referenced this issue Apr 15, 2024
@defstat
pkp#9887 Change User Email Invitation Prototype
4b80cd1
defstat added a commit to defstat/ojs that referenced this issue May 9, 2024
@defstat
pkp/pkp-lib#9887 API Support
3ae80bc
defstat added a commit to defstat/ojs that referenced this issue May 9, 2024
@defstat
pkp/pkp-lib#9887 Redesigning Invitations
6c40287
defstat added a commit to defstat/ojs that referenced this issue May 9, 2024
@defstat
pkp/pkp-lib#9887 Add ChangeProfileEmail Invitation
7b17d9d
defstat added a commit to defstat/pkp-lib that referenced this issue May 9, 2024
@defstat
pkp#9887 Redesign Invitations
0f64eb9
defstat added a commit to defstat/pkp-lib that referenced this issue May 9, 2024
@defstat
pkp#9887 Add ChangeProfileEmail Invitation
2e0fa16
@asmecher
Copy link
Member

Thanks, @defstat, I've added a review on pkp-lib: #9888 (review)

defstat added a commit to defstat/pkp-lib that referenced this issue May 28, 2024
@defstat
pkp#9887 Redesign Invitations
0b8340e
defstat added a commit to defstat/pkp-lib that referenced this issue May 28, 2024
@defstat
pkp#9887 Add ChangeProfileEmail Invitation
0a037fc
defstat added a commit to defstat/pkp-lib that referenced this issue May 28, 2024
@defstat
pkp#9887 Review Changes
a2d22ef
defstat added a commit to defstat/pkp-lib that referenced this issue May 28, 2024
@defstat
pkp#9887 GetActionUrl change
d4d3517
defstat added a commit to defstat/ojs that referenced this issue May 28, 2024
@defstat
pkp/pkp-lib#9887 API Support
055d844
defstat added a commit to defstat/ojs that referenced this issue May 28, 2024
@defstat
pkp/pkp-lib#9887 Redesigning Invitations
2def923
defstat added a commit to defstat/ojs that referenced this issue May 28, 2024
@defstat
pkp/pkp-lib#9887 Add ChangeProfileEmail Invitation
c18ad91
defstat added a commit to defstat/ojs that referenced this issue May 31, 2024
@defstat
pkp/pkp-lib#9887 API Support
08e9136
defstat added a commit to defstat/ojs that referenced this issue May 31, 2024
@defstat
pkp/pkp-lib#9887 Redesigning Invitations
8653d86
defstat added a commit to defstat/ojs that referenced this issue May 31, 2024
@defstat
pkp/pkp-lib#9887 Add ChangeProfileEmail Invitation
5306158
defstat added a commit to defstat/pkp-lib that referenced this issue May 31, 2024
@defstat
pkp#9887 Redesign Invitations
217eb46
defstat added a commit to defstat/pkp-lib that referenced this issue May 31, 2024
@defstat
pkp#9887 Add new discovery pattern
c3a7db1
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Jun 4, 2024
@defstat @asmecher
pkp#9887 Redesign Invitations
98a1171
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Jun 4, 2024
@defstat @asmecher
pkp#9887 Add new discovery pattern
c95c3d6
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jun 4, 2024
@asmecher
pkp#9887 Remove unnecessary PKP classname prefixes
5263773
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jun 4, 2024
@asmecher
pkp#9887 Fix copyright dates for new code
fbc7ea2
asmecher pushed a commit to asmecher/ojs that referenced this issue Jun 4, 2024
@defstat @asmecher
pkp/pkp-lib#9887 API Support
640590b
asmecher pushed a commit to asmecher/ojs that referenced this issue Jun 4, 2024
@defstat @asmecher
pkp/pkp-lib#9887 Redesigning Invitations
4b3175a
asmecher pushed a commit to asmecher/ojs that referenced this issue Jun 4, 2024
@defstat @asmecher
pkp/pkp-lib#9887 Add ChangeProfileEmail Invitation
3712773
asmecher added a commit to asmecher/ojs that referenced this issue Jun 4, 2024
@asmecher
pkp/pkp-lib#9887 Remove unnecessary PKP classname prefixes
50ac7ae
asmecher added a commit to asmecher/ojs that referenced this issue Jun 4, 2024
@asmecher
pkp/pkp-lib#9887 Fix copyright dates for new code
047f514
asmecher added a commit to asmecher/ojs that referenced this issue Jun 4, 2024
@asmecher
pkp/pkp-lib#9887 Submodule update ##asmecher/i9887##
07d528c
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jun 4, 2024
@asmecher
pkp#9887 Add email template on upgrade
24589df
asmecher added a commit to asmecher/ojs that referenced this issue Jun 4, 2024
@asmecher
pkp/pkp-lib#9887 Add email template on upgrade
e21ffe8
asmecher added a commit to asmecher/ojs that referenced this issue Jun 4, 2024
@asmecher
pkp/pkp-lib#9887 Submodule update ##asmecher/i9887##
8a22584
asmecher added a commit to asmecher/ojs that referenced this issue Jun 4, 2024
@asmecher
pkp/pkp-lib#9887 Submodule update ##asmecher/i9887##
078dee5
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jun 4, 2024
@asmecher
pkp#9887 Don't put hash method into function name
e92f233
asmecher added a commit to asmecher/ojs that referenced this issue Jun 4, 2024
@asmecher
pkp/pkp-lib#9887 Don't put hash method into function name
5a6b53d
asmecher added a commit to asmecher/ojs that referenced this issue Jun 4, 2024
@asmecher
pkp/pkp-lib#9887 Submodule update ##asmecher/i9887##
d63180e
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jun 4, 2024
@asmecher
pkp#9887 Add missing locale keys for mailables
5311233
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jun 4, 2024
@asmecher
pkp#9887 Email change invitation should not use journal-specific vari…
de58f81 
…ables
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jun 4, 2024
@asmecher
pkp#9887 Make function naming consistent
6edc3df
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jun 4, 2024
@asmecher
pkp#9887 Add PKP button styling
f4692d3
asmecher added a commit that referenced this issue Jun 4, 2024
@asmecher @defstat
[PKP-LIB][main] #9887 Invitation API Support (#10013)
011ebb8 
* #9887 Redesign Invitations

* #9887 Add new discovery pattern

* #9887 Remove unnecessary PKP classname prefixes

* #9887 Fix copyright dates for new code

* #9887 Add email template on upgrade

* #9887 Don't put hash method into function name

* #9887 Add missing locale keys for mailables

* #9887 Email change invitation should not use journal-specific variables

* #9887 Make function naming consistent

* #9887 Add PKP button styling

---------

Co-authored-by: Dimitris Efstathiou <[email protected]>
asmecher added a commit to pkp/ojs that referenced this issue Jun 4, 2024
@asmecher @defstat
[OJS][main] #9887 Invitation API Support (#4297)
bdcf224 
* pkp/pkp-lib#9887 API Support

* pkp/pkp-lib#9887 Redesigning Invitations

* pkp/pkp-lib#9887 Add ChangeProfileEmail Invitation

* pkp/pkp-lib#9887 Remove unnecessary PKP classname prefixes

* pkp/pkp-lib#9887 Fix copyright dates for new code

* pkp/pkp-lib#9887 Add email template on upgrade

* pkp/pkp-lib#9887 Don't put hash method into function name

* pkp/pkp-lib#9887 Submodule update ##asmecher/i9887##

---------

Co-authored-by: Dimitris Efstathiou <[email protected]>
@asmecher
Copy link
Member

asmecher commented Jun 4, 2024

Thanks, @defstat, I added a few commits and merged the following PRs based on yours:

I've also ported the app-specific changes to OMP and OPS main.

@asmecher asmecher closed this as completed Jun 4, 2024
@asmecher asmecher added this to the 3.5.0 LTS milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@defstat defstat

Labels
None yet
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
2 participants
@asmecher @defstat