-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusability of handler helper methods #33
Comments
ctgraham
added a commit
to ulsdevteam/texture
that referenced
this issue
Oct 17, 2019
Also, this transformation of mime type to genre: probably not robust enough for texture/TextureHandler.inc.php Lines 177 to 199 in bbac9e8
|
Concrete example (if we want to keep it to the plugin): |
ctgraham
added a commit
to ulsdevteam/texture
that referenced
this issue
Oct 17, 2019
ctgraham
added a commit
to ulsdevteam/texture
that referenced
this issue
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Methods
TextureHandler::_createDependentFile()
andTextureHandler::_updateManuscriptFile()
seem reusable enough that they could be methods of the Plugin, or even ofSubmissionFileManager
.For example, for #32, we would want a plugin hook to potentially do both of these things. There would be no need to reach out to a
Handler
.@withanage , @asmecher , opinions on whether to promote these methods to the plugin or to
SubmissionFileManager
? Are there assumptions or specifics I'm missing here which limit the reusability of this code?The text was updated successfully, but these errors were encountered: