Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing enum value #642

Closed
aditya-arcot opened this issue Aug 22, 2024 · 4 comments
Closed

Missing enum value #642

aditya-arcot opened this issue Aug 22, 2024 · 4 comments

Comments

@aditya-arcot
Copy link

aditya-arcot commented Aug 22, 2024

This enum SandboxItemFireWebhookRequestWebhookCodeEnum should include LOGIN_REPAIRED as this is a valid webhook code for the sandbox item fire webhook endpoint.

Link to documentation

The documentation is also not in sync for this endpoint.
The endpoint summary section lists LOGIN_REPAIRED as a valid webhook code, but is missing AUTHORIZATION_GRANTED.
The webhook_code specification in the request fields section includes AUTHORIZATION_GRANTED, but not LOGIN_REPAIRED.

@phoenixy1
Copy link
Contributor

@aditya-arcot this is a similar issue to plaid/plaid-java#426 -- the /sandbox/item/fire_webhook endpoint supports only a limited subset of webhook codes. LOGIN_REPAIRED is one of the webhook codes it doesn't support, which is why it is not present in the enum.

@aditya-arcot
Copy link
Author

aditya-arcot commented Aug 22, 2024

LOGIN_REPAIRED is supported by this endpoint, as mentioned in the documentation at the link I provided

The /sandbox/item/fire_webhook endpoint is used to test that code correctly handles webhooks. This endpoint can trigger the following webhooks:
...
LOGIN_REPAIRED: Fired when an Item recovers from the ITEM_LOGIN_REQUIRED without the user going through update mode in your app.

@phoenixy1 phoenixy1 reopened this Aug 22, 2024
@phoenixy1
Copy link
Contributor

Oops, I missed that! Thanks for the correction. I've submitted a PR to fix this and it should be resolved in the next client library update.

@aditya-arcot
Copy link
Author

No problem, sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants