From 4b830d30f8e02633e35e0253ca93110d59845bfa Mon Sep 17 00:00:00 2001
From: eseiker <eseiker@users.noreply.github.com>
Date: Fri, 18 Oct 2024 18:40:34 +0900
Subject: [PATCH] use ClusterIP for seed, rpc, validator if gateway is enabled

---
 .../multiplanetary/network/9c-network.yaml    |  1 -
 .../multiplanetary/network/heimdall.yaml      |  1 -
 .../all-in-one/templates/gateway-route.yaml   |  2 +-
 charts/all-in-one/templates/service.yaml      | 28 +++++++++++++++----
 4 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/9c-internal/multiplanetary/network/9c-network.yaml b/9c-internal/multiplanetary/network/9c-network.yaml
index e3cc175f..6846cc07 100644
--- a/9c-internal/multiplanetary/network/9c-network.yaml
+++ b/9c-internal/multiplanetary/network/9c-network.yaml
@@ -30,7 +30,6 @@ ingress:
 
 gateway:
   enabled: true
-  hostname: gateway-internal-odin.planetarium.network
   services:
     - hostname: odin-internal-rpc.nine-chronicles.com
       backendRefs:
diff --git a/9c-internal/multiplanetary/network/heimdall.yaml b/9c-internal/multiplanetary/network/heimdall.yaml
index 30a8923d..174f93ad 100644
--- a/9c-internal/multiplanetary/network/heimdall.yaml
+++ b/9c-internal/multiplanetary/network/heimdall.yaml
@@ -32,7 +32,6 @@ ingress:
 
 gateway:
   enabled: true
-  hostname: gateway-internal-heimdall.planetarium.network
   services:
     - hostname: heimdall-internal-rpc.nine-chronicles.com
       backendRefs:
diff --git a/charts/all-in-one/templates/gateway-route.yaml b/charts/all-in-one/templates/gateway-route.yaml
index ae6a5773..d39af897 100644
--- a/charts/all-in-one/templates/gateway-route.yaml
+++ b/charts/all-in-one/templates/gateway-route.yaml
@@ -31,7 +31,7 @@ spec:
             labelselector: app.kubernetes.io/instance=traefik-{{ $.Release.Name }}
         gatewayClass:
           name: traefik-{{ $.Release.Name }}
-        globalArguments:
+        additionalArguments:
           - --providers.kubernetesgateway.statusaddress.service.name=traefik-{{ $.Release.Name }}
           - --providers.kubernetesgateway.statusaddress.service.namespace={{ $.Release.Name }}
         service:
diff --git a/charts/all-in-one/templates/service.yaml b/charts/all-in-one/templates/service.yaml
index 89150dae..90906162 100644
--- a/charts/all-in-one/templates/service.yaml
+++ b/charts/all-in-one/templates/service.yaml
@@ -8,17 +8,16 @@ metadata:
   labels:
     app.kubernetes.io/instance: {{ $.Release.Name }}
   annotations:
-    {{- with $.Values.global.service.annotations }}
-      {{- toYaml . | nindent 4 }}
-    {{- end }}
+    {{- if not $.Values.gateway.enabled }}
+    {{- toYaml $.Values.global.service.annotations | nindent 4 }}
     service.beta.kubernetes.io/aws-load-balancer-target-group-attributes: stickiness.enabled=true,stickiness.type=source_ip,preserve_client_ip.enabled=true
     service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags: Environment={{- if eq $.Values.clusterName "9c-main-v2" }}production{{- else }}development{{- end }},Team=game,Owner=jihyung,Service={{ $.Release.Name }},Name=tcp-seed-{{ $index }}
     {{- if index $.Values.seed.hosts $idx }}
     external-dns.alpha.kubernetes.io/hostname: {{ index $.Values.seed.hosts $idx }}
     external-dns.alpha.kubernetes.io/ttl: '60'
     {{- end }}
+    {{- end }}
 spec:
-  externalTrafficPolicy: Local
   ports:
   - port: {{ $.Values.seed.ports.node }}
     targetPort: {{ $.Values.seed.ports.node }}
@@ -36,7 +35,12 @@ spec:
     name: gossip
   selector:
     app: tcp-seed-{{ $index }}
+  {{- if not $.Values.gateway.enabled }}
   type: LoadBalancer
+  externalTrafficPolicy: Local
+  {{- else }}
+  type: ClusterIP
+  {{- end }}
 ---
 {{ end }}
 
@@ -51,6 +55,7 @@ metadata:
   labels:
     app.kubernetes.io/instance: {{ $.Release.Name }}
   annotations:
+    {{- if not $.Values.gateway.enabled }}
     {{- toYaml $.Values.global.service.annotations | nindent 4 }}
     service.beta.kubernetes.io/aws-load-balancer-target-group-attributes: stickiness.enabled=true,stickiness.type=source_ip,preserve_client_ip.enabled=true
     service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags: Environment={{- if eq $.Values.clusterName "9c-main-v2" }}production{{- else }}development{{- end }},Team=game,Owner=jihyung,Service={{ $.Release.Name }},Name=remote-headless-{{ $index }}
@@ -58,8 +63,8 @@ metadata:
     external-dns.alpha.kubernetes.io/hostname: {{ index $.Values.remoteHeadless.hosts $idx }}
     external-dns.alpha.kubernetes.io/ttl: '60'
     {{- end }}
+    {{- end }}
 spec:
-  externalTrafficPolicy: Local
   ports:
   - name: graphql
     port: {{ $.Values.remoteHeadless.ports.graphql }}
@@ -75,7 +80,12 @@ spec:
     targetPort: {{ $.Values.remoteHeadless.ports.graphql }}
   selector:
     app: remote-headless-{{ $index }}
+  {{- if not $.Values.gateway.enabled }}
   type: LoadBalancer
+  externalTrafficPolicy: Local
+  {{- else }}
+  type: ClusterIP
+  {{- end }}
 
 ---
 {{ end }}
@@ -530,6 +540,7 @@ metadata:
   labels:
     app.kubernetes.io/instance: {{ $.Release.Name }}
   annotations:
+    {{- if not $.Values.gateway.enabled }}
     {{- toYaml $.Values.global.service.annotations | nindent 4 }}
     service.beta.kubernetes.io/aws-load-balancer-target-group-attributes: stickiness.enabled=true,stickiness.type=source_ip,preserve_client_ip.enabled=true
     service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags: Environment={{- if eq $.Values.clusterName "9c-main-v2" }}production{{- else }}development{{- end }},Team=game,Owner=jihyung,Service={{ $.Release.Name }},Name=validator-{{ $index }}
@@ -537,8 +548,8 @@ metadata:
     external-dns.alpha.kubernetes.io/hostname: {{ index $.Values.validator.hosts $idx }}
     external-dns.alpha.kubernetes.io/ttl: '60'
     {{- end }}
+    {{- end }}
 spec:
-  externalTrafficPolicy: Local
   ports:
   - port: {{ $.Values.validator.ports.headless }}
     targetPort: {{ $.Values.validator.ports.headless }}
@@ -555,7 +566,12 @@ spec:
     protocol: TCP
   selector:
     app: validator-{{ $index }}
+  {{- if not $.Values.gateway.enabled }}
   type: LoadBalancer
+  externalTrafficPolicy: Local
+  {{- else }}
+  type: ClusterIP
+  {{- end }}
 
 ---
 {{ end }}