From 47e79c5e3c43ade6c4928dc7147819782ba74a7b Mon Sep 17 00:00:00 2001 From: Harshil Patel <26harshilpatel11@gmail.com> Date: Mon, 14 Oct 2024 23:03:33 -0400 Subject: [PATCH 1/3] Update ProposeGenesis in TestUtils to remove redundant Initialize() --- test/Libplanet.Tests/TestUtils.cs | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/test/Libplanet.Tests/TestUtils.cs b/test/Libplanet.Tests/TestUtils.cs index 2d582511f26..7cb6fe6c0ee 100644 --- a/test/Libplanet.Tests/TestUtils.cs +++ b/test/Libplanet.Tests/TestUtils.cs @@ -422,19 +422,18 @@ public static PreEvaluationBlock ProposeGenesis( var txs = transactions?.ToList() ?? new List(); long nonce = 0; validatorSet = validatorSet ?? ValidatorSet; - txs.AddRange( - validatorSet.Validators.Select( - validator => Transaction.Create( - nonce++, - GenesisProposer, - null, - actions: new IAction[] - { - new Initialize( - validatorSet: validatorSet, - states: ImmutableDictionary.Create()), - }.Select(x => x.PlainValue), - timestamp: DateTimeOffset.MinValue))); + txs.Add( + Transaction.Create( + nonce++, + GenesisProposer, + null, + actions: new IAction[] + { + new Initialize( + validatorSet: validatorSet, + states: ImmutableDictionary.Create()), + }.Select(x => x.PlainValue), + timestamp: DateTimeOffset.MinValue)); txs = txs.OrderBy(tx => tx.Id).ToList(); var content = new BlockContent( From b631910a8717f5b277b8a3853fd83c489af835ed Mon Sep 17 00:00:00 2001 From: ilgyu Date: Wed, 16 Oct 2024 15:39:49 +0900 Subject: [PATCH 2/3] test: Fix AEV test fixture --- test/Libplanet.Tests/Action/ActionEvaluatorTest.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/Libplanet.Tests/Action/ActionEvaluatorTest.cs b/test/Libplanet.Tests/Action/ActionEvaluatorTest.cs index 6a465c66a5e..5eeacce7ce3 100644 --- a/test/Libplanet.Tests/Action/ActionEvaluatorTest.cs +++ b/test/Libplanet.Tests/Action/ActionEvaluatorTest.cs @@ -596,9 +596,9 @@ DumbAction MakeAction(Address address, char identifier, Address? transferTo = nu // have to be updated, since the order may change due to different PreEvaluationHash. expectations = new (int TxIdx, int ActionIdx, string[] UpdatedStates, Address Signer)[] { - (2, 0, new[] { "A", "B", "C", null, "F" }, _txFx.Address3), - (1, 0, new[] { "A", "B", "C", "E", "F" }, _txFx.Address2), - (0, 0, new[] { "A,D", "B", "C", "E", "F" }, _txFx.Address1), + (1, 0, new[] { "A", "B", "C", "E", null }, _txFx.Address2), + (0, 0, new[] { "A,D", "B", "C", "E", null }, _txFx.Address1), + (2, 0, new[] { "A,D", "B", "C", "E", "F" }, _txFx.Address3), }; Assert.Equal(expectations.Length, evals.Length); foreach (var (expect, eval) in expectations.Zip(evals, (x, y) => (x, y))) From ef139b640d4b1288af0cc769e9e8afeee1be4b27 Mon Sep 17 00:00:00 2001 From: ilgyu Date: Fri, 18 Oct 2024 11:00:08 +0900 Subject: [PATCH 3/3] test: Fix MessageId fixture --- test/Libplanet.Net.Tests/Messages/MessageTest.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Libplanet.Net.Tests/Messages/MessageTest.cs b/test/Libplanet.Net.Tests/Messages/MessageTest.cs index b98a1b5f4c3..106a1cf46b5 100644 --- a/test/Libplanet.Net.Tests/Messages/MessageTest.cs +++ b/test/Libplanet.Net.Tests/Messages/MessageTest.cs @@ -115,7 +115,7 @@ public void GetId() var message = new BlockHeaderMsg(genesis.Hash, genesis.Header); Assert.Equal( new MessageId(ByteUtil.ParseHex( - "1aa2c8fad502f8890b2e8cf6f9afe57e6f718f454f14f8304165e921b28905bf")), + "1d4296f8e28bfc873a5e72cbbd17454d7cf2dbee86c2481e4876e236f8ae2dee")), message.Id); }