diff --git a/consensus/beacon/oplegacy.go b/consensus/beacon/oplegacy.go index c7793c893..8e94cfa60 100644 --- a/consensus/beacon/oplegacy.go +++ b/consensus/beacon/oplegacy.go @@ -57,7 +57,7 @@ func (o *OpLegacy) VerifyUncles(chain consensus.ChainReader, block *types.Block) } func (o *OpLegacy) Prepare(chain consensus.ChainHeaderReader, header *types.Header) error { - return nil + return fmt.Errorf("cannot prepare for legacy block header: %s (num %d)", header.Hash(), header.Number) } func (o *OpLegacy) Finalize(chain consensus.ChainHeaderReader, header *types.Header, state *state.StateDB, body *types.Body) { diff --git a/miner/worker.go b/miner/worker.go index 0e39b9618..5ade00938 100644 --- a/miner/worker.go +++ b/miner/worker.go @@ -39,6 +39,12 @@ import ( "github.com/holiman/uint256" ) +const ( + // minRecommitInterruptInterval is the minimum time interval used to interrupt filling a + // sealing block with pending transactions from the mempool + minRecommitInterruptInterval = 2 * time.Second +) + var ( errBlockInterruptedByNewHead = errors.New("new head arrived while building block") errBlockInterruptedByRecommit = errors.New("recommit interrupt while building block") @@ -128,7 +134,7 @@ func (miner *Miner) generateWork(params *generateParams) *newPayloadResult { if interrupt == nil { interrupt = new(atomic.Int32) } - timer := time.AfterFunc(miner.config.Recommit, func() { + timer := time.AfterFunc(max(minRecommitInterruptInterval, miner.config.Recommit), func() { interrupt.Store(commitInterruptTimeout) }) @@ -260,8 +266,10 @@ func (miner *Miner) makeEnv(parent *types.Header, header *types.Header, coinbase if historicalBackend, ok := miner.backend.(BackendWithHistoricalState); ok { var release tracers.StateReleaseFunc parentBlock := miner.backend.BlockChain().GetBlockByHash(parent.Hash()) - state, release, _ = historicalBackend.StateAtBlock(context.Background(), parentBlock, ^uint64(0), nil, false, false) - // TODO: handle error returned by StateAtBlock + state, release, err = historicalBackend.StateAtBlock(context.Background(), parentBlock, ^uint64(0), nil, false, false) + if err != nil { + return nil, err + } state = state.Copy() release() }