Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flag to disable shutdown endpoint #46

Open
UiP9AV6Y opened this issue Jan 26, 2022 · 0 comments · May be fixed by #49
Open

add flag to disable shutdown endpoint #46

UiP9AV6Y opened this issue Jan 26, 2022 · 0 comments · May be fixed by #49

Comments

@UiP9AV6Y
Copy link

the /quitquitquit endpoint allows any authenticated user to shut down the service. not sure what the point of it is, but would like to have the ability to disable this endpoint (maybe use the same approach as for the /kubecfg endpoint; use the NotImplemented handler when the endpoint is disabled)

out current workaround is to filter requests to /quitquitquit on the authenticating proxy upstream.
UiP9AV6Y added a commit to UiP9AV6Y/kubehook that referenced this issue Jan 26, 2022
@UiP9AV6Y
make shutdown endpoint optional via CLI flag.
1f4e44e 
this change adds a new CLI flag, which allows the `/quitquitquit`
endpoint to be replaced with a noop action instead of the default
"shutdown the application" behaviour.

for backwards compatibility, the endpoint remains armed by default.

closes planetlabs#46
@UiP9AV6Y UiP9AV6Y linked a pull request Jan 26, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make shutdown endpoint optional via CLI flag. UiP9AV6Y/kubehook
1 participant
@UiP9AV6Y